[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 6/7] block/stream: use block_job_throttle
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH 6/7] block/stream: use block_job_throttle |
Date: |
Thu, 14 Dec 2017 09:50:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 14/12/2017 01:59, John Snow wrote:
> Signed-off-by: John Snow <address@hidden>
> ---
> block/stream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/stream.c b/block/stream.c
> index e85af18c54..3ad3190387 100644
> --- a/block/stream.c
> +++ b/block/stream.c
> @@ -139,7 +139,7 @@ static void coroutine_fn stream_run(void *opaque)
> /* Note that even when no rate limit is applied we need to yield
> * with no pending I/O here so that bdrv_drain_all() returns.
> */
> - block_job_sleep_ns(&s->common, delay_ns);
> + block_job_throttle(&s->common, delay_ns);
> if (block_job_is_cancelled(&s->common)) {
> break;
> }
>
Nit, the previous patch is adding a blank line here, but this one isn't.
Reviewed-by: Paolo Bonzini <address@hidden>
- Re: [Qemu-block] [PATCH 3/7] blockjob: create block_job_throttle, (continued)
[Qemu-block] [PATCH 6/7] block/stream: use block_job_throttle, John Snow, 2017/12/13
[Qemu-block] [PATCH 7/7] block/backup: use block_job_throttle, John Snow, 2017/12/13