qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH V4] pci: removed the is_express fie


From: Eduardo Habkost
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH V4] pci: removed the is_express field since a uniform interface was inserted
Date: Mon, 18 Dec 2017 11:23:54 -0200
User-agent: Mutt/1.9.1 (2017-09-22)

On Tue, Dec 12, 2017 at 07:36:49AM +0200, Yoni Bettan wrote:
>         * according to Eduardo Habkost's commit
>           fd3b02c8896d597dd8b9e053dec579cf0386aee1
> 
>         * since all PCIEs now implement INTERFACE_PCIE_DEVICE we
>           don't need this field anymore
> 
>         * Devices that where only INTERFACE_PCIE_DEVICE (is_express == 1)
>           or
>           devices that where only INTERFACE_CONVENTIONAL_PCI_DEVICE 
> (is_express == 0)
>           where not affected by the change
> 
>           The only devices that were affected are those that are hybrid and 
> also
>           had (is_express == 1) - therefor only:
>             - hw/vfio/pci.c
>             - hw/usb/hcd-xhci.c

Oops, we now have xen-pt too.  See:

  From: Simon Gaiser <address@hidden>
  Date: Sat, 28 Oct 2017 04:53:15 +0200
  Message-Id: <address@hidden>
  Subject: [PATCH] xen/pt: Set is_express to avoid out-of-bounds write

Which was included in a pull request sent on last Thursday.

> 
>           For both I made sure that QEMU_PCI_CAP_EXPRESS is on
> 
> Signed-off-by: Yoni Bettan <address@hidden>
[...]

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]