[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 02/19] block: Assert drain_all is only called fro
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PATCH v2 02/19] block: Assert drain_all is only called from main AioContext |
Date: |
Thu, 21 Dec 2017 15:22:34 +0100 |
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
---
block/io.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/io.c b/block/io.c
index cf780c3cb0..b94740b8ff 100644
--- a/block/io.c
+++ b/block/io.c
@@ -330,6 +330,12 @@ void bdrv_drain_all_begin(void)
BdrvNextIterator it;
GSList *aio_ctxs = NULL, *ctx;
+ /* BDRV_POLL_WHILE() for a node can only be called from its own I/O thread
+ * or the main loop AioContext. We potentially use BDRV_POLL_WHILE() on
+ * nodes in several different AioContexts, so make sure we're in the main
+ * context. */
+ assert(qemu_get_current_aio_context() == qemu_get_aio_context());
+
block_job_pause_all();
for (bs = bdrv_first(&it); bs; bs = bdrv_next(&it)) {
--
2.13.6
- [Qemu-block] [PATCH v2 00/19] Drain fixes and cleanups, part 2, Kevin Wolf, 2017/12/21
- [Qemu-block] [PATCH v2 01/19] block: Remove unused bdrv_requests_pending, Kevin Wolf, 2017/12/21
- [Qemu-block] [PATCH v2 02/19] block: Assert drain_all is only called from main AioContext,
Kevin Wolf <=
- [Qemu-block] [PATCH v2 04/19] test-bdrv-drain: Test callback for bdrv_drain, Kevin Wolf, 2017/12/21
- [Qemu-block] [PATCH v2 06/19] blockjob: Pause job on draining any job BDS, Kevin Wolf, 2017/12/21
- [Qemu-block] [PATCH v2 03/19] block: Make bdrv_drain() driver callbacks non-recursive, Kevin Wolf, 2017/12/21
- [Qemu-block] [PATCH v2 05/19] test-bdrv-drain: Test bs->quiesce_counter, Kevin Wolf, 2017/12/21
- [Qemu-block] [PATCH v2 07/19] test-bdrv-drain: Test drain vs. block jobs, Kevin Wolf, 2017/12/21
- [Qemu-block] [PATCH v2 08/19] block: Don't block_job_pause_all() in bdrv_drain_all(), Kevin Wolf, 2017/12/21
- [Qemu-block] [PATCH v2 09/19] block: Nested drain_end must still call callbacks, Kevin Wolf, 2017/12/21
- [Qemu-block] [PATCH v2 11/19] block: Don't notify parents in drain call chain, Kevin Wolf, 2017/12/21
- [Qemu-block] [PATCH v2 12/19] block: Add bdrv_subtree_drained_begin/end(), Kevin Wolf, 2017/12/21
- [Qemu-block] [PATCH v2 10/19] test-bdrv-drain: Test nested drain sections, Kevin Wolf, 2017/12/21