[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v7 14/20] sheepdog: Switch to .bdrv_co_block_status(
From: |
Eric Blake |
Subject: |
[Qemu-block] [PATCH v7 14/20] sheepdog: Switch to .bdrv_co_block_status() |
Date: |
Fri, 5 Jan 2018 16:57:47 -0600 |
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the sheepdog driver accordingly.
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
---
v7: rebase to minor spacing changes in master
v5-v6: no change
v4: update to interface tweak
v3: no change
v2: rebase to mapping flag
---
block/sheepdog.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index f684477328..8a7b688ece 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -2987,19 +2987,19 @@ static coroutine_fn int sd_co_pdiscard(BlockDriverState
*bs, int64_t offset,
return acb.ret;
}
-static coroutine_fn int64_t
-sd_co_get_block_status(BlockDriverState *bs, int64_t sector_num, int
nb_sectors,
- int *pnum, BlockDriverState **file)
+static coroutine_fn int
+sd_co_block_status(BlockDriverState *bs, bool want_zero, int64_t offset,
+ int64_t bytes, int64_t *pnum, int64_t *map,
+ BlockDriverState **file)
{
BDRVSheepdogState *s = bs->opaque;
SheepdogInode *inode = &s->inode;
uint32_t object_size = (UINT32_C(1) << inode->block_size_shift);
- uint64_t offset = sector_num * BDRV_SECTOR_SIZE;
unsigned long start = offset / object_size,
- end = DIV_ROUND_UP((sector_num + nb_sectors) *
- BDRV_SECTOR_SIZE, object_size);
+ end = DIV_ROUND_UP(offset + bytes, object_size);
unsigned long idx;
- int64_t ret = BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID | offset;
+ *map = offset;
+ int ret = BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID;
for (idx = start; idx < end; idx++) {
if (inode->data_vdi_id[idx] == 0) {
@@ -3016,9 +3016,9 @@ sd_co_get_block_status(BlockDriverState *bs, int64_t
sector_num, int nb_sectors,
}
}
- *pnum = (idx - start) * object_size / BDRV_SECTOR_SIZE;
- if (*pnum > nb_sectors) {
- *pnum = nb_sectors;
+ *pnum = (idx - start) * object_size;
+ if (*pnum > bytes) {
+ *pnum = bytes;
}
if (ret > 0 && ret & BDRV_BLOCK_OFFSET_VALID) {
*file = bs;
@@ -3096,7 +3096,7 @@ static BlockDriver bdrv_sheepdog = {
.bdrv_co_writev = sd_co_writev,
.bdrv_co_flush_to_disk = sd_co_flush_to_disk,
.bdrv_co_pdiscard = sd_co_pdiscard,
- .bdrv_co_get_block_status = sd_co_get_block_status,
+ .bdrv_co_block_status = sd_co_block_status,
.bdrv_snapshot_create = sd_snapshot_create,
.bdrv_snapshot_goto = sd_snapshot_goto,
@@ -3132,7 +3132,7 @@ static BlockDriver bdrv_sheepdog_tcp = {
.bdrv_co_writev = sd_co_writev,
.bdrv_co_flush_to_disk = sd_co_flush_to_disk,
.bdrv_co_pdiscard = sd_co_pdiscard,
- .bdrv_co_get_block_status = sd_co_get_block_status,
+ .bdrv_co_block_status = sd_co_block_status,
.bdrv_snapshot_create = sd_snapshot_create,
.bdrv_snapshot_goto = sd_snapshot_goto,
@@ -3168,7 +3168,7 @@ static BlockDriver bdrv_sheepdog_unix = {
.bdrv_co_writev = sd_co_writev,
.bdrv_co_flush_to_disk = sd_co_flush_to_disk,
.bdrv_co_pdiscard = sd_co_pdiscard,
- .bdrv_co_get_block_status = sd_co_get_block_status,
+ .bdrv_co_block_status = sd_co_block_status,
.bdrv_snapshot_create = sd_snapshot_create,
.bdrv_snapshot_goto = sd_snapshot_goto,
--
2.14.3
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 06/20] iscsi: Switch iscsi_allocmap_update() to byte-based, (continued)
- [Qemu-block] [PATCH v7 07/20] iscsi: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 08/20] null: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 09/20] parallels: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 10/20] qcow: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 11/20] qcow2: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 13/20] raw: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 12/20] qed: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 14/20] sheepdog: Switch to .bdrv_co_block_status(),
Eric Blake <=
- [Qemu-block] [PATCH v7 15/20] vdi: Avoid bitrot of debugging code, Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 16/20] vdi: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 17/20] vmdk: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 18/20] vpc: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 19/20] vvfat: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-block] [PATCH v7 20/20] block: Drop unused .bdrv_co_get_block_status(), Eric Blake, 2018/01/05
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver callbacks, no-reply, 2018/01/07