Re: [Qemu-block] [Qemu-devel] [PATCH] raw: Disable probing if image format is given by driver-specific options

[Max Reitz]

On 2018-01-22 08:21, Lin Ma wrote:
> If the user specifies image format through driver-specific options, The
> format probing should be prohibited and the warning message should not
> be printed.
> 
> e.g.:
> $ qemu-system-x86_64 ... -drive file.file.filename=disk0.raw,file.driver=raw 
> ...
> WARNING: Image format was not specified for 'disk0.raw' and probing guessed 
> raw.
>          Automatically detecting the format is dangerous for raw images, ...
> 
> Signed-off-by: Lin Ma <address@hidden>
> ---
>  blockdev.c | 2 ++
>  1 file changed, 2 insertions(+)

But what has been proped is the driver for the root BDS, so the warning
is actually correct.

(That command line is creating a chain of three BDS:
raw (probed) -> raw (explicitly specified) -> file (default protocol))

Max

signature.asc
Description: OpenPGP digital signature