[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/2] qemu-iotests: add missing rule to build soc
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH 1/2] qemu-iotests: add missing rule to build socket_scm_helper |
Date: |
Mon, 29 Jan 2018 16:02:37 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 2017-12-19 17:37, Philippe Mathieu-Daudé wrote:
> 'make check-block' uses it on Linux.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index b4bcc872f2..fa5e9597f1 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -919,7 +919,7 @@ check-qapi-schema: $(patsubst %,check-%,
> $(check-qapi-schema-y)) check-tests/qap
> check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS))
> check-unit: $(patsubst %,check-%, $(check-unit-y))
> check-speed: $(patsubst %,check-%, $(check-speed-y))
> -check-block: $(patsubst %,check-%, $(check-block-y))
> +check-block: $(patsubst %,check-%, $(check-block-y))
> QEMU_IOTESTS_HELPERS-$(CONFIG_LINUX)
> check: check-qapi-schema check-unit check-qtest
> check-clean:
> $(MAKE) -C tests/tcg clean
First, shouldn't it be $(QEMU_IOTESTS_HELPERS-y)?
Secondly, it seems that is already a dependency of
check-tests/qemu-iotests-quick.sh, which is basically what
$(check-block-y) is. So even without that dependency here,
socket_scm_helper is built when I run make check-block and it's missing.
Max
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-block] [PATCH 1/2] qemu-iotests: add missing rule to build socket_scm_helper,
Max Reitz <=