qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v5 2/2] qemu-img: Document --force-share / -U


From: Max Reitz
Subject: Re: [Qemu-block] [PATCH v5 2/2] qemu-img: Document --force-share / -U
Date: Mon, 29 Jan 2018 17:01:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 2017-12-26 03:52, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: Kashyap Chamarthy <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  qemu-img.texi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/qemu-img.texi b/qemu-img.texi
> index 60a0e080c6..e83e140f7a 100644
> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -86,6 +86,15 @@ exclusive with the @var{-O} parameters. It is currently 
> required to also use
>  the @var{-n} parameter to skip image creation. This restriction may be 
> relaxed
>  in a future release.
>  
> address@hidden --force-share (-U)
> +

So the previous patch makes the use of blank lines consistent and this
one breaks it again? :-)

> +If specified, @code{qemu-img} will open the image with shared permissions,
> +which makes it less likely to conflict with a running guest's permissions due
> +to image locking. For example, this can be used to get the image information
> +(with 'info' subcommand) when the image is used by a running guest. Note that
> +this could produce inconsistent results because of concurrent metadata 
> changes,
> +etc. This option is only allowed when opening images in read-only mode.

I personally don't quite like the "makes it less likely to conflict",
because that makes it sound like qemu would be stupid and need a nudge
in the right direction -- when it's actually the user who does something
a bit risky (and qemu is right in forbidding it by default).  But since
it's only a read-only thing, I won't actually object to it.

(Maybe it should document more exactly what's happening, i.e. that this
option will allow concurrent writers (as a standard user, I wouldn't
know what "shared permissions" is supposed to mean).)

Max

> +
>  @item --backing-chain
>  will enumerate information about backing files in a disk image chain. Refer
>  below for further description.
> 


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]