[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] hbitmap: fix missing restore count
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization |
Date: |
Wed, 31 Jan 2018 14:01:39 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/31/2018 01:54 PM, Max Reitz wrote:
> On 2018-01-18 11:58, Liang Li wrote:
>> The .count of HBitmap is forgot to set in function
>> hbitmap_deserialize_finish, let's set it to the right value.
>>
>> Cc: Vladimir Sementsov-Ogievskiy <address@hidden>
>> Cc: Fam Zheng <address@hidden>
>> Cc: Max Reitz <address@hidden>
>> Cc: John Snow <address@hidden>
>> Signed-off-by: weiping zhang <address@hidden>
>> Signed-off-by: Liang Li <address@hidden>
>> ---
>> util/hbitmap.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/util/hbitmap.c b/util/hbitmap.c
>> index 289778a..58a2c93 100644
>> --- a/util/hbitmap.c
>> +++ b/util/hbitmap.c
>> @@ -630,6 +630,7 @@ void hbitmap_deserialize_finish(HBitmap *bitmap)
>> }
>>
>> bitmap->levels[0][0] |= 1UL << (BITS_PER_LONG - 1);
>> + bitmap->count = hb_count_between(bitmap, 0, bitmap->size - 1);
>> }
>>
>> void hbitmap_free(HBitmap *hb)
>
> Actually CC-ing John...
>
> (Looks good to me, though.)
>
> Max
>
Staged already, sorry. Will send the PR this Friday.
https://github.com/jnsnow/qemu/commit/78ad6913bd34a54f658d5182990fe149614d6402
signature.asc
Description: OpenPGP digital signature