[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 12/13] blockjob: privatize block_job_sleep_ns
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2 12/13] blockjob: privatize block_job_sleep_ns |
Date: |
Wed, 7 Feb 2018 23:47:35 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 2018-01-19 21:58, John Snow wrote:
> There's not currently any external caller of it.
>
> Except in tests, but we'll fix that here too.
>
> Replace usages in test cases with block_job_relax, which functions
> similarly enough to be used as a drop-in replacement.
>
> Very technically block_job_sleep_ns(job, 0) behaves differently
> from block_job_relax(job, 0) in that relax may resolve to a no-op,
> but this makes no difference in the test in which it is used.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> blockjob.c | 11 ++++++++++-
> include/block/blockjob_int.h | 11 -----------
> tests/test-bdrv-drain.c | 2 +-
> tests/test-blockjob-txn.c | 2 +-
> 4 files changed, 12 insertions(+), 14 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-block] [PATCH v2 12/13] blockjob: privatize block_job_sleep_ns,
Max Reitz <=