Re: [Qemu-block] [PATCH] nbd: Honor server's advertised minimum block size

[Eric Blake]

On 02/16/2018 05:50 AM, Vladimir Sementsov-Ogievskiy wrote:
> 15.02.2018 06:29, Eric Blake wrote:
> > Commit 79ba8c98 (v2.7) changed the setting of request_alignment
> > to occur only during bdrv_refresh_limits(), rather than at at
> > bdrv_open() time; but at the time, NBD was unaffected, because
> > it still used sector-based callbacks, so the block layer
> > defaulted NBD to use 512 request_alignment.

> > Fix these issues by moving the assignment to request_alignment
> > to the right function, and by using a sane default when the
> > server does not advertise a minimum size.
> >
> > CC: address@hidden
> > Signed-off-by: Eric Blake <address@hidden>
> > ---

> Reviewed-by: Vladimir Sementsov-Ogievskiy<address@hidden>

Thanks; applied to my NBD queue.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org