Re: [Qemu-block] [PATCH v2 16/36] file-win32: Support .bdrv_co_create

[Eric Blake]

On 02/21/2018 07:53 AM, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to file-win32, which
> enables image creation over QMP.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
>   block/file-win32.c | 45 +++++++++++++++++++++++++++++++++++++--------
>   1 file changed, 37 insertions(+), 8 deletions(-)

> +
> +    options = (BlockdevCreateOptions) {
> +        .driver     = BLOCKDEV_DRIVER_FILE,
> +        .u.file     = {
> +            .filename           = (char *) filename,
> +            .size               = total_size,
> +            .has_preallocation  = false,
> +            .has_nocow          = false,

Technically, these last two lines aren't needed (you get false by 
default), but it doesn't hurt to list them either.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org