qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] block: make BDRV_POLL_WHILE() re-entrancy safe


From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH] block: make BDRV_POLL_WHILE() re-entrancy safe
Date: Tue, 6 Mar 2018 12:08:44 +0100
User-agent: Mutt/1.9.1 (2017-09-22)

Am 06.03.2018 um 11:53 hat Stefan Hajnoczi geschrieben:
> Nested BDRV_POLL_WHILE() calls can occur.  Currently
> assert(!bs_->wakeup) will fail when this happens.
> 
> This patch converts bs->wakeup from bool to a counter.
> 
> Nesting works correctly because outer BDRV_POLL_WHILE() callers evaluate
> the condition again after the inner caller completes (invoking the inner
> caller counts as aio_poll() progress).
> 
> Reported-by: "fuweiwei (C)" <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>

Doesn't this conflict with your own AIO_WAIT_WHILE() patch?

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]