Re: [Qemu-block] [Qemu-devel] [PATCH 1/7] qemu-img: Amendment support implies create_opts

[Eric Blake]

On 04/21/2018 11:54 AM, Max Reitz wrote:
> Instead of checking whether a driver has a non-NULL create_opts we
> should check whether it supports image amendment in the first place.  If
> it does, it must have create_opts.
>
> On the other hand, if it does not have create_opts (so it does not
> support amendment either), the error message "does not support any
> options" is a bit useless.  Stating clearly that the driver has no
> amendment support whatsoever is probably better.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
>   qemu-img.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org