Re: [Qemu-block] [Qemu-devel] [PATCH 6/7] iotests: Test help option for unsupporting formats

[Eric Blake]

On 04/21/2018 11:54 AM, Max Reitz wrote:
> This adds test cases to 082 for qemu-img create/convert/amend "-o help"
> on formats that do not support creation or amendment, respectively.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
>   tests/qemu-iotests/082     | 9 +++++++++
>   tests/qemu-iotests/082.out | 9 +++++++++
>   2 files changed, 18 insertions(+)
>
> diff --git a/tests/qemu-iotests/082 b/tests/qemu-iotests/082
> index d5c83d45ed..a872f771a6 100755
> --- a/tests/qemu-iotests/082
> +++ b/tests/qemu-iotests/082
> @@ -97,6 +97,9 @@ run_qemu_img create -f $IMGFMT -o backing_file="$TEST_IMG" -o ,, 
> -o help "$TEST_
>   run_qemu_img create -f $IMGFMT -o help
>   run_qemu_img create -o help
>   
> +# Try help option for a format that does not support creation
> +run_qemu_img create -f bochs -o help

If we ever get brave enough to add creation support for bochs, hopefully 
we figure out what iotests need tweaking at that point (realistically, I 
don't see that ever happening).

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org