Re: [Qemu-block] [RFC 0/7] block: Try to use correctly typed blockdev options

[Max Reitz]

On 2018-05-02 23:32, Max Reitz wrote:
> (Sorry, Markus, sorry, Kevin, if this series makes you angry.)
> 
> The subject says it all, I think.  The original issue I was assigned to
> solve is this:
> 
>     $ ./qemu-img info --image-opts driver=null-co,size=42
>     image: json:{"driver": "null-co", "size": "42"}
>     [...]
> 
> As you can see, "size" gets a string value in the json:{} object
> although it is an integer, according to the QAPI schema.  (Buglink:
> https://bugzilla.redhat.com/show_bug.cgi?id=1534396)
> 
> My first approach to fix this was to try to pipe the full_open_options
> dict generated in bdrv_refresh_filename() through a keyval input visitor
> and then an output visitor (which would have depended on my filename
> series).  This did not work out because bs->options (where all of the
> reconstructed options come from) may either be correctly typed or not,
> and keyval chokes on non-string values.  I could have probably converted
> bs->options to fully string values before trying to pipe it through
> keyval, but I decided I didn't like that very much.  (I suppose I can be
> convinced otherwise, though.)
> 
> So I decided to venture into the territory of what we actually want at
> some point: Correctly typed bs->options.  Or, rather, in the end we want
> bs->options to be BlockdevOptions, but let's not be too hasty here.
> 
> So it turns out that with really just a bit of work we can separate the
> interfaces that generate correctly typed options (e.g. blockdev-add)
> from the ones that generate pure string-valued options (e.g. qemu-img
> --image-opts) rather well.  Once we have done that, we can pipe all of
> the pure string options through keyval and back to get correctly typed
> options.
> 
> So far the theory.  Now, in practice we of course have pitfalls, and
> those are not addressed by this series, which is the main reason this is
> an RFC.
> 
> The first pitfall (I can see...) is that json:{} allows you to specify
> mixed options -- some values are incorrectly strings, others are
> non-strings.  keyval cannot cope with that, so the result after this
> series is that those options end up in bs->options just like that.  I
> suppose we could just forbid that mixed-typed case, though, and call it
> a bug fix.
> 
> The second problem (and I think the big reason why we have not
> approached this issue so far) is that there are options which you can
> give as strings, but which are not covered by the schema.  In such a
> case, the input visitor will reject the QDict and we will just use it
> as-is, that is, full of strings.  Now that is not what we want in the
> end, of course -- we want everything to be converted into something that
> is covered by the schema.
> 
> My reasoning for sending this series anyway is that it doesn't make
> things worse (bs->options is a mess already, you can never be certain
> that it contains correctly typed values or just strings or both), and
> that it at least gives a starting point from which we can continue on.
> After this series, we have a clear separation between the interfaces
> that use purely string values and the ones that provide correct typing
> (well, and json:{}).
> 
> Oh, and it fixes the above BZ for the more common cases.
> 
> 
> Max Reitz (7):
>   qdict: Add qdict_set_default_bool()
>   block: Let change-medium add detect-zeroes as bool
>   block: Make use of qdict_set_default_bool()
>   block: Add bdrv_open_string_opts()
>   block: Add blk_new_open_string_opts()
>   block: Use {blk_new,bdrv}_open_string_opts()
>   iotests: Test internal option typing
> 
>  include/block/block.h          |  2 +
>  include/qapi/qmp/qdict.h       |  1 +
>  include/sysemu/block-backend.h |  2 +
>  block.c                        | 96 
> ++++++++++++++++++++++++++++++++++++++----
>  block/block-backend.c          | 30 ++++++++++++-
>  block/vvfat.c                  |  4 +-
>  blockdev.c                     | 33 ++++++++++-----
>  qemu-img.c                     |  3 +-
>  qemu-io.c                      |  2 +-
>  qemu-nbd.c                     |  2 +-
>  qobject/qdict.c                | 13 ++++++
>  tests/test-replication.c       |  6 +--
>  tests/qemu-iotests/089         | 12 ++++++
>  tests/qemu-iotests/089.out     |  5 +++
>  14 files changed, 183 insertions(+), 28 deletions(-)

(Forgot to mention: This series depends on my "qemu-io/img: Fix
-U/force-share conflict testing" series.

Based-on: <address@hidden>

But who builds an RFC anyway... *me ducks*)

signature.asc
Description: OpenPGP digital signature