[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 01/67] block: use local path for local headers
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [Qemu-block] [PATCH 01/67] block: use local path for local headers |
|
Date: |
Fri, 4 May 2018 10:32:12 +0100 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, May 03, 2018 at 10:50:20PM +0300, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
This commit message is wrong. Directory paths work by design, since
we explicitly add -I$SRCDIR to the include path.
If we want to drop -I$SRCDIR, lets be clear about that being the
reason, rather than pretending this is an accident.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|