[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH] sheepdog: Remove unnecessary NULL check in sd_preal
From: |
Peter Maydell |
Subject: |
[Qemu-block] [PATCH] sheepdog: Remove unnecessary NULL check in sd_prealloc() |
Date: |
Fri, 18 May 2018 19:17:17 +0100 |
In commit 8b9ad56e9cbfd852a, we removed the code that could result
in our getting to sd_prealloc()'s out_with_err_set label with a
NULL blk pointer. That makes the NULL check in the error-handling
path unnecessary, and Coverity gripes about it (CID 1390636).
Delete the redundant check.
Signed-off-by: Peter Maydell <address@hidden>
---
block/sheepdog.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 4237132419..2a5bc0a59a 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -1859,9 +1859,7 @@ out:
error_setg_errno(errp, -ret, "Can't pre-allocate");
}
out_with_err_set:
- if (blk) {
- blk_unref(blk);
- }
+ blk_unref(blk);
g_free(buf);
return ret;
--
2.17.0
- [Qemu-block] [PATCH] sheepdog: Remove unnecessary NULL check in sd_prealloc(),
Peter Maydell <=