[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 17/40] job: Move BlockJobCreateF
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 17/40] job: Move BlockJobCreateFlags to Job |
|
Date: |
Wed, 23 May 2018 18:24:56 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/18/2018 09:20 AM, Kevin Wolf wrote:
> + job->auto_finalize = !(flags & JOB_MANUAL_FINALIZE);
> + job->auto_dismiss = !(flags & JOB_MANUAL_DISMISS);
Job API might be a good chance to say "No, this is the default behavior
for this API."
I don't know how possible this is, but could we remove these behavior
flags for jobs (but keep them for block jobs), and then any legacy block
job creation interfaces we have can enable/disable them as the user
requested,
and the block job layer itself has hooks that persuade the core job
layer to automatically transition without user input, if appropriate.
(Unless that happens later?)
- [Qemu-block] [PATCH v2 10/40] job: Move cancelled to Job, (continued)
- [Qemu-block] [PATCH v2 10/40] job: Move cancelled to Job, Kevin Wolf, 2018/05/18
- [Qemu-block] [PATCH v2 14/40] job: Add job_sleep_ns(), Kevin Wolf, 2018/05/18
- [Qemu-block] [PATCH v2 12/40] job: Move defer_to_main_loop to Job, Kevin Wolf, 2018/05/18
- [Qemu-block] [PATCH v2 15/40] job: Move pause/resume functions to Job, Kevin Wolf, 2018/05/18
- [Qemu-block] [PATCH v2 16/40] job: Replace BlockJob.completed with job_is_completed(), Kevin Wolf, 2018/05/18
- [Qemu-block] [PATCH v2 13/40] job: Move coroutine and related code to Job, Kevin Wolf, 2018/05/18
- [Qemu-block] [PATCH v2 18/40] blockjob: Split block_job_event_pending(), Kevin Wolf, 2018/05/18
- [Qemu-block] [PATCH v2 17/40] job: Move BlockJobCreateFlags to Job, Kevin Wolf, 2018/05/18
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 17/40] job: Move BlockJobCreateFlags to Job,
John Snow <=
- [Qemu-block] [PATCH v2 19/40] job: Add job_event_*(), Kevin Wolf, 2018/05/18
- [Qemu-block] [PATCH v2 21/40] job: Convert block_job_cancel_async() to Job, Kevin Wolf, 2018/05/18
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 21/40] job: Convert block_job_cancel_async() to Job, John Snow, 2018/05/23
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 21/40] job: Convert block_job_cancel_async() to Job, Kevin Wolf, 2018/05/24
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 21/40] job: Convert block_job_cancel_async() to Job, John Snow, 2018/05/24
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 21/40] job: Convert block_job_cancel_async() to Job, Kevin Wolf, 2018/05/25
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 21/40] job: Convert block_job_cancel_async() to Job, John Snow, 2018/05/25
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 21/40] job: Convert block_job_cancel_async() to Job, Kashyap Chamarthy, 2018/05/29