[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 00/16] AHCI: tracing improvements
From: |
no-reply |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 00/16] AHCI: tracing improvements |
Date: |
Fri, 25 May 2018 17:11:18 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/16] AHCI: tracing improvements
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/address@hidden -> patchew/address@hidden
t [tag update] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
6e9eac25b6 ahci: make ahci_mem_write traces more descriptive
0e9178a8a3 ahci: delete old host register address definitions
3564c2a548 ahci: adjust ahci_mem_write to work on registers
cc62a192cf ahci: fix spacing damage on ahci_mem_write
b92ccc4dc0 ahci: make mem_read_32 traces more descriptive
c70ee985e4 ahci: modify ahci_mem_read_32 to work on register numbers
0c503fd064 ahci: fix host register max address
3296ccc062 ahci: add host register enumeration
69baf78e85 ahci: delete old port register address definitions
059ca5a176 ahci: make port write traces more descriptive
5907e28690 ahci: modify ahci_port_write to use register numbers
cc6578bfe2 ahci: combine identical clauses in port write
bd7bb50ca6 ahci: fix spacing damage on ahci_port_write
4f6e337a4f ahci: make port read traces more descriptive
c629998268 ahci: modify ahci_port_read to use register numbers
f01e729be1 ahci: add port register enumeration
=== OUTPUT BEGIN ===
Checking PATCH 1/16: ahci: add port register enumeration...
WARNING: line over 80 characters
#71: FILE: hw/ide/ahci_internal.h:94:
+ AHCI_PORT_REG_SCR_NOTIF = 15, /* PxSNTF: SATA phy register:
SNotification */
total: 0 errors, 1 warnings, 72 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/16: ahci: modify ahci_port_read to use register numbers...
Checking PATCH 3/16: ahci: make port read traces more descriptive...
Checking PATCH 4/16: ahci: fix spacing damage on ahci_port_write...
ERROR: spaces required around that '|' (ctx:VxV)
#83: FILE: hw/ide/ahci.c:316:
+ (val & ~(PORT_CMD_RO_MASK|PORT_CMD_ICC_MASK));
^
total: 1 errors, 0 warnings, 156 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/16: ahci: combine identical clauses in port write...
Checking PATCH 6/16: ahci: modify ahci_port_write to use register numbers...
Checking PATCH 7/16: ahci: make port write traces more descriptive...
Checking PATCH 8/16: ahci: delete old port register address definitions...
Checking PATCH 9/16: ahci: add host register enumeration...
Checking PATCH 10/16: ahci: fix host register max address...
Checking PATCH 11/16: ahci: modify ahci_mem_read_32 to work on register
numbers...
Checking PATCH 12/16: ahci: make mem_read_32 traces more descriptive...
Checking PATCH 13/16: ahci: fix spacing damage on ahci_mem_write...
Checking PATCH 14/16: ahci: adjust ahci_mem_write to work on registers...
Checking PATCH 15/16: ahci: delete old host register address definitions...
Checking PATCH 16/16: ahci: make ahci_mem_write traces more descriptive...
WARNING: line over 80 characters
#18: FILE: hw/ide/ahci.c:493:
+ trace_ahci_mem_write_host_unimpl(s, size,
AHCIHostReg_lookup[regnum],
total: 0 errors, 1 warnings, 29 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-block] [PATCH 08/16] ahci: delete old port register address definitions, (continued)
- [Qemu-block] [PATCH 08/16] ahci: delete old port register address definitions, John Snow, 2018/05/25
- [Qemu-block] [PATCH 07/16] ahci: make port write traces more descriptive, John Snow, 2018/05/25
- [Qemu-block] [PATCH 01/16] ahci: add port register enumeration, John Snow, 2018/05/25
- [Qemu-block] [PATCH 02/16] ahci: modify ahci_port_read to use register numbers, John Snow, 2018/05/25
- [Qemu-block] [PATCH 06/16] ahci: modify ahci_port_write to use register numbers, John Snow, 2018/05/25
- [Qemu-block] [PATCH 11/16] ahci: modify ahci_mem_read_32 to work on register numbers, John Snow, 2018/05/25
- [Qemu-block] [PATCH 15/16] ahci: delete old host register address definitions, John Snow, 2018/05/25
- [Qemu-block] [PATCH 14/16] ahci: adjust ahci_mem_write to work on registers, John Snow, 2018/05/25
- [Qemu-block] [PATCH 12/16] ahci: make mem_read_32 traces more descriptive, John Snow, 2018/05/25
- [Qemu-block] [PATCH 16/16] ahci: make ahci_mem_write traces more descriptive, John Snow, 2018/05/25
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/16] AHCI: tracing improvements,
no-reply <=