[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 01/14] vdi: Fix vdi_co_do_create() return value
From: |
Jeff Cody |
Subject: |
Re: [Qemu-block] [PATCH 01/14] vdi: Fix vdi_co_do_create() return value |
Date: |
Tue, 29 May 2018 10:45:07 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, May 25, 2018 at 06:33:14PM +0200, Kevin Wolf wrote:
> .bdrv_co_create() is supposed to return 0 on success, but vdi could
> return a positive value instead. Fix this.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/vdi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/vdi.c b/block/vdi.c
> index 96a22b8e83..668af0a828 100644
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -865,6 +865,7 @@ static int coroutine_fn
> vdi_co_do_create(BlockdevCreateOptions *create_options,
> }
> }
>
> + ret = 0;
> exit:
> blk_unref(blk);
> bdrv_unref(bs_file);
> --
> 2.13.6
>
>
Reviewed-by: Jeff Cody <address@hidden>