|
From: | Eric Blake |
Subject: | Re: [Qemu-block] [Qemu-devel] [PATCH 0/8] block: more byte-based cleanups: vectored I/O |
Date: | Tue, 29 May 2018 10:00:39 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 05/28/2018 06:19 AM, Kevin Wolf wrote:
Am 25.04.2018 um 20:32 hat Eric Blake geschrieben:Based-on: <address@hidden> ([PATCH v2 0/6] block: byte-based AIO read/write) Based-on: <address@hidden> ([PATCH] block: Merge .bdrv_co_writev{, _flags} in drivers) My quest continues. I spent some time pruning qcow down as far as possible (and was dismayed at how long it took to prove no iotests regressions); so for the other drivers, I did the bare minimum to get rid of an interface, but will leave it to those file owners if they want to get rid of further pointless sector manipulations in their files. Next on the chopping block: bdrv_read/bdrv_write.Nice series, looks good apart from a few minor comments on the qcow1 conversion.
For qcow1, I kept things at 512-byte alignment throughout; as the format is not for new users, I find it easier to assert that things are aligned than to worry about sub-sector requests. But yes, I can improve things according to your comments for v2.
For v2, can you please make sure to have proper CCs also on the cover letter?
Does git-publish do this automatically? (If so, it's time for me to start using it...)
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |