Re: [Qemu-block] [PATCH v7 00/10] qemu-img convert with copy offloading

[Fam Zheng]

On Wed, 05/30 17:06, Stefan Hajnoczi wrote:
> On Tue, May 29, 2018 at 01:59:49PM +0800, Fam Zheng wrote:
> > v7: Fix qcow2.
> > 
> > v6: Pick up rev-by from Stefan and Eric.
> >     Tweak patch 2 commit message.
> > 
> > v5: - Fix raw offset/bytes check for read. [Eric]
> >     - Fix qcow2_handle_l2meta. [Stefan]
> >     - Add coroutine_fn whereever appropriate. [Stefan]
> > 
> > v4: - Fix raw offset and size. [Eric]
> >     - iscsi: Drop unnecessary return values and variables in favor of
> >       constants. [Stefan]
> >     - qcow2: Handle small backing case. [Stefan]
> >     - file-posix: Translate ENOSYS to ENOTSUP. [Stefan]
> >     - API documentation and commit message. [Stefan]
> >     - Add rev-by to patches 3, 5 - 10. [Stefan, Eric]
> > 
> > This series introduces block layer API for copy offloading and makes use of 
> > it
> > in qemu-img convert.
> > 
> > For now we implemented the operation in local file protocol with
> > copy_file_range(2).  Besides that it's possible to add similar to iscsi, nfs
> > and potentially more.
> > 
> > As far as its usage goes, in addition to qemu-img convert, we can emulate
> > offloading in scsi-disk (handle EXTENDED COPY command), and use the API in
> > block jobs too.
> 
> Fails to compile on Fedora 28.
> 
> Oops, I guess my glibc is too new.  This type of bug doesn't happen very
> often :D :D :D.
> 
> block/file-posix.c:1452:14: error: static declaration of ‘copy_file_range’ 
> follows non-static declaration
>  static off_t copy_file_range(int in_fd, off_t *in_off, int out_fd,
>               ^~~~~~~~~~~~~~~
> In file included from /home/stefanha/qemu/include/qemu/osdep.h:75,
>                  from block/file-posix.c:25:
> /usr/include/unistd.h:1107:9: note: previous declaration of ‘copy_file_range’ 
> was here
>  ssize_t copy_file_range (int __infd, __off64_t *__pinoff,
>          ^~~~~~~~~~~~~~~

It means it's time to update our Fedora docker image! Will fix this by adding a
configure test.

Fam