[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 04/18] xen: create xenstore areas for XenDevice-
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-block] [PATCH 04/18] xen: create xenstore areas for XenDevice-s |
Date: |
Wed, 5 Dec 2018 13:58:39 +0000 |
User-agent: |
Mutt/1.11.1 (2018-12-01) |
On Wed, Dec 05, 2018 at 12:43:57PM +0000, Paul Durrant wrote:
> > > > + value = g_strdup_vprintf(fmt, ap);
> > >
> > > Looks like g_vasprintf() would be better, since it returns the lenght as
> > > well.
> > >
> >
> > Yes.
>
> I tried this and it appears not to exist in the version of glib in my
> environment so I guess I'll stick with g_strdup_printf().
It's probably because you need to include "glib/gprintf.h", I've
suggested it because I've seen the function use elsewhere in QEMU. But
g_strdup_printf is fine too.
https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-vasprintf
--
Anthony PERARD