[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few |
Date: |
Fri, 14 Dec 2018 10:22:11 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Dec 13, 2018 at 11:37:37PM +0100, Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be exempted from the check.
> Outside those, after this patch the following files still contain both
> 8-space and TAB sequences at the beginning of the line. Many of them
> have a majority of TABs, or were initially committed with all tabs.
> crypto/aes.c
Since you already cleaned some tabs in the previous patch, and the
rest of crypto/ except desrfb.c is tab-clean, I'd like this to be
fully cleaned too.
> ui/vnc-enc-hextile-template.h
> ui/vnc-enc-zywrle.h
The VNC code was historically heavily tab-damaged and we've
progressively cleaned it up when making changes.
> The following have only TABs:
> crypto/desrfb.c
I'd rather like this to be cleaned to finish the job for
crypto/.
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> ui/vnc-enc-zywrle-template.c | 4 +-
> ui/vnc.c | 4 +-
That you've finished tab-cleaning of these files, reinforces to
me that we should clean those other vnc files listed above.
None the less
Reviewed-by: Daniel P. Berrangé <address@hidden>
since those ones mentioned above can still be done as a separate
commit to this.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few, Paolo Bonzini, 2018/12/13
- Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few, Richard Henderson, 2018/12/13
- Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few, David Gibson, 2018/12/13
- Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few, Michael S. Tsirkin, 2018/12/13
- Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few,
Daniel P . Berrangé <=
- Re: [Qemu-block] [SPAM] [Qemu-ppc] [PATCH 2/2] avoid TABs in files that only contain a few, Greg Kurz, 2018/12/14
- Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few, Peter Maydell, 2018/12/14
- Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few, Alex Bennée, 2018/12/14
- Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few, Stefan Hajnoczi, 2018/12/14
- Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few, Michael S. Tsirkin, 2018/12/14
- Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] avoid TABs in files that only contain a few, Aleksandar Markovic, 2018/12/14
- Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few, Eric Blake, 2018/12/14
- Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few, Stefan Markovic, 2018/12/17