[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 05/13] io: Remove redundant read/write_corout
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH v2 05/13] io: Remove redundant read/write_coroutine assignments |
|
Date: |
Thu, 21 Feb 2019 10:03:55 +0100 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Am 20.02.2019 um 19:22 hat Paolo Bonzini geschrieben:
> On 20/02/19 19:07, Kevin Wolf wrote:
> > Am 20.02.2019 um 19:01 hat Paolo Bonzini geschrieben:
> >> aio_co_wake was also acquiring/releasing the AioContext, so
> >> that needs to stay for now.
> >
> > True. Maybe I should leave the aio_co_wake call alone() and just add the
> > assertion to avoid complicating the code rather than simplifying it...
>
> Yes, I agree.
Okay, I made this change locally. I'm not sending a v3 for this, but
will just directly merge it if no other comments come up.
> ps: where is alone() defined? :)
#define aio_co_wake aio_co_wake()
#define alone() alone
Here. :-)
Kevin
- [Qemu-block] [PATCH v2 00/13] block: bdrv_set_aio_context() related fixes, Kevin Wolf, 2019/02/20
- [Qemu-block] [PATCH v2 01/13] block-backend: Make blk_inc/dec_in_flight public, Kevin Wolf, 2019/02/20
- [Qemu-block] [PATCH v2 02/13] virtio-blk: Increase in_flight for request restart BH, Kevin Wolf, 2019/02/20
- [Qemu-block] [PATCH v2 03/13] nbd: Restrict connection_co reentrance, Kevin Wolf, 2019/02/20
- [Qemu-block] [PATCH v2 04/13] io: Make qio_channel_yield() interruptible, Kevin Wolf, 2019/02/20
- [Qemu-block] [PATCH v2 05/13] io: Remove redundant read/write_coroutine assignments, Kevin Wolf, 2019/02/20
[Qemu-block] [PATCH v2 06/13] nbd: Move nbd_read_eof() to nbd/client.c, Kevin Wolf, 2019/02/20
[Qemu-block] [PATCH v2 07/13] nbd: Use low-level QIOChannel API in nbd_read_eof(), Kevin Wolf, 2019/02/20
[Qemu-block] [PATCH v2 10/13] block: Fix AioContext switch for drained node, Kevin Wolf, 2019/02/20
[Qemu-block] [PATCH v2 08/13] nbd: Increase bs->in_flight during AioContext switch, Kevin Wolf, 2019/02/20
[Qemu-block] [PATCH v2 11/13] test-bdrv-drain: AioContext switch in drained section, Kevin Wolf, 2019/02/20
[Qemu-block] [PATCH v2 09/13] block: Don't poll in bdrv_set_aio_context(), Kevin Wolf, 2019/02/20
[Qemu-block] [PATCH v2 12/13] block: Use normal drain for bdrv_set_aio_context(), Kevin Wolf, 2019/02/20
[Qemu-block] [PATCH v2 13/13] aio-posix: Assert that aio_poll() is always called in home thread, Kevin Wolf, 2019/02/20
Re: [Qemu-block] [PATCH v2 00/13] block: bdrv_set_aio_context() related fixes, Kevin Wolf, 2019/02/25