[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH for-QEMU-4.1 v5 02/29] hw/ide/ahci:
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH for-QEMU-4.1 v5 02/29] hw/ide/ahci: Add a Kconfig switch for the AHDI-ICH9 device |
Date: |
Thu, 25 Apr 2019 15:19:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/20/19 12:31 PM, Philippe Mathieu-Daudé wrote:
> On 4/18/19 8:00 PM, Thomas Huth wrote:
>> Some of our machines (like the ARM cubieboard) use CONFIG_AHCI for an AHCI
>> sysbus device, but do not use CONFIG_PCI since they do not feature a PCI
>> bus. With CONFIG_AHCI but without CONFIG_PCI, currently linking fails:
>>
>> ../hw/ide/ich.o: In function `pci_ich9_ahci_realize':
>> hw/ide/ich.c:124: undefined reference to `pci_allocate_irq'
>> hw/ide/ich.c:126: undefined reference to `pci_register_bar'
>> hw/ide/ich.c:128: undefined reference to `pci_register_bar'
>> hw/ide/ich.c:131: undefined reference to `pci_add_capability'
>> hw/ide/ich.c:147: undefined reference to `msi_init'
>> ../hw/ide/ich.o: In function `pci_ich9_uninit':
>> hw/ide/ich.c:158: undefined reference to `msi_uninit'
>> ../hw/ide/ich.o:(.data.rel+0x50): undefined reference to
>> `vmstate_pci_device'
>>
>> We must only compile ich.c if CONFIG_PCI is available, too, so introduce a
>> new config switch for this device.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Oops, "AHCI" in patch subject (D -> C).
- [Qemu-block] [PATCH for-QEMU-4.1 v5 00/29] Kconfig dependencies for ARM machines, Thomas Huth, 2019/04/18
- [Qemu-block] [PATCH for-QEMU-4.1 v5 01/29] hw/pci/pci-stub: Add msi_enabled() and msi_notify() to the pci stubs, Thomas Huth, 2019/04/18
- [Qemu-block] [PATCH for-QEMU-4.1 v5 04/29] hw/arm: Express dependencies of the exynos machines with Kconfig, Thomas Huth, 2019/04/18
- [Qemu-block] [PATCH for-QEMU-4.1 v5 02/29] hw/ide/ahci: Add a Kconfig switch for the AHDI-ICH9 device, Thomas Huth, 2019/04/18
- [Qemu-block] [PATCH for-QEMU-4.1 v5 05/29] hw/arm: Express dependencies of the highbank machines with Kconfig, Thomas Huth, 2019/04/18
- [Qemu-block] [PATCH for-QEMU-4.1 v5 03/29] hw/usb/hcd-ohci: Move PCI-related code into a separate file, Thomas Huth, 2019/04/18
- [Qemu-block] [PATCH for-QEMU-4.1 v5 06/29] hw/arm: Express dependencies of integratorcp with Kconfig, Thomas Huth, 2019/04/18
- [Qemu-block] [PATCH for-QEMU-4.1 v5 07/29] hw/arm: Express dependencies of the fsl-imx31 machine with Kconfig, Thomas Huth, 2019/04/18