qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 19/21] block: Mark bdrv_root_unref_child() GRAPH_WRLOCK


From: Stefan Hajnoczi
Subject: Re: [PATCH 19/21] block: Mark bdrv_root_unref_child() GRAPH_WRLOCK
Date: Tue, 22 Aug 2023 15:38:38 -0400

On Thu, Aug 17, 2023 at 02:50:18PM +0200, Kevin Wolf wrote:
> Instead of taking the writer lock internally, require callers to already
> hold it when calling bdrv_root_unref_child(). These callers will
> typically already hold the graph lock once the locking work is
> completed, which means that they can't call functions that take it
> internally.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  include/block/block_int-global-state.h | 2 +-
>  block.c                                | 6 +++---
>  block/block-backend.c                  | 3 +++
>  blockjob.c                             | 2 ++
>  4 files changed, 9 insertions(+), 4 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]