[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 19/21] block: Mark bdrv_root_unref_child() GRAPH_WRLOCK
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 19/21] block: Mark bdrv_root_unref_child() GRAPH_WRLOCK |
Date: |
Tue, 22 Aug 2023 15:38:38 -0400 |
On Thu, Aug 17, 2023 at 02:50:18PM +0200, Kevin Wolf wrote:
> Instead of taking the writer lock internally, require callers to already
> hold it when calling bdrv_root_unref_child(). These callers will
> typically already hold the graph lock once the locking work is
> completed, which means that they can't call functions that take it
> internally.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> include/block/block_int-global-state.h | 2 +-
> block.c | 6 +++---
> block/block-backend.c | 3 +++
> blockjob.c | 2 ++
> 4 files changed, 9 insertions(+), 4 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH 04/21] block: Take AioContext lock for bdrv_append() more consistently, (continued)
- [PATCH 08/21] block: Mark bdrv_replace_child_noperm() GRAPH_WRLOCK, Kevin Wolf, 2023/08/17
- [PATCH 06/21] block-coroutine-wrapper: Add no_co_wrapper_bdrv_wrlock functions, Kevin Wolf, 2023/08/17
- [PATCH 19/21] block: Mark bdrv_root_unref_child() GRAPH_WRLOCK, Kevin Wolf, 2023/08/17
- [PATCH 05/21] block: Introduce bdrv_schedule_unref(), Kevin Wolf, 2023/08/17
- Re: [PATCH 05/21] block: Introduce bdrv_schedule_unref(), Stefan Hajnoczi, 2023/08/22
- [PATCH 07/21] block-coroutine-wrapper: Allow arbitrary parameter names, Kevin Wolf, 2023/08/17
- [PATCH 10/21] block: Mark bdrv_attach_child_common() GRAPH_WRLOCK, Kevin Wolf, 2023/08/17