Re: [PATCH v3 0/2] qemu-img: map: implement support for compressed clusters

[Eric Blake]

On Fri, Sep 22, 2023 at 12:10:45PM +0200, Kevin Wolf wrote:
> > 
> > In the patches applied to master something went wrong and my email isn't
> > displayed correctly:
> > 
> > > commit 2848289168fbbd9a6855c84ec8fde8929a2b042b
> > > Author: Andrey Drobyshev via <qemu-block@nongnu.org>   <--------
> > > Date:   Fri Sep 8 00:02:25 2023 +0300
> > > 
> > >     block: add BDRV_BLOCK_COMPRESSED flag for bdrv_block_status()
> > 
> > > commit 52b10c9c0c68e90f9503ba578f2eaf8975c1977f        
> > > Author: Andrey Drobyshev via <qemu-block@nongnu.org>   <--------
> > > Date:   Fri Sep 8 00:02:26 2023 +0300
> > > 
> > >     qemu-img: map: report compressed data blocks
> > 
> > There's probably no way to fix that in master, but just giving you a
> > heads-up for maybe there's a bug in your scripts.
> 
> Yes, too late to fix it in master. I would have to notice this earlier
> and then fix it manually.

If I recall, Peter had scripts that would automatically reject pull
requests that have this issue.  I don't know if there is a technical
reason why they can't be made part of our CI engine, vs. having to be
copied over to every other developer that also takes on a release
manager role.

> 
> But it's not a bug on my side (I'm only using 'git am' anyway), this is
> actually how the email is sent by Mailman:
> 
> From: Andrey Drobyshev via <qemu-devel@nongnu.org>
> 
> You can see the same problem in Patchew:
> 
> 20230919165804.439110-1-andrey.drobyshev@virtuozzo.com/">https://patchew.org/QEMU/20230919165804.439110-1-andrey.drobyshev@virtuozzo.com/
> 
> If I understand correctly, the problem is with the DMARC policy of
> virtuozzo.com, which forces the mailing list to rewrite the From: header
> in order to avoid being treated as spam:
> 
> https://wiki.list.org/DEV/DMARC
> 
> I don't know why it happens only on some of your emails, though.

I had to manually adjust it on patches I recently sent through my NBD
tree.  I also know we can edit .mailmap to give you proper attribution
after the fact (if we haven't already).

Meanwhile, if I recall, there is a way to set up 'git config' so that
'git format-patch' or 'git send-email' creates emails that, after list
mangling to work around DMARC, look like:

| To: list...
| normal headers...
| From: name via qemu-devel <qemu-devel@nongnu.org>
| Subject: my patch
| 
| From: name <real email>
| 
| Next line of commit message

but I couldn't quickly google for what that setting would be ('git
format-patch --help | grep -i dmarc' had no hits).  The important part
is that the added 'From: real line' in the first line of the body of
the email overrides any mangled From: line in the headers.

Maybe someone that has worked around the issue can chime in with the
magic setting?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org