qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] python/qmp: remove Server.wait_closed() call for Python


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH 2/4] python/qmp: remove Server.wait_closed() call for Python 3.12
Date: Fri, 6 Oct 2023 23:35:03 +0300
User-agent: Mozilla Thunderbird

On 06.10.23 22:52, John Snow wrote:
This patch is a backport from
https://gitlab.com/qemu-project/python-qemu-qmp/-/commit/e03a3334b6a477beb09b293708632f2c06fe9f61

According to Guido in https://github.com/python/cpython/issues/104344 ,
this call was never meant to wait for the server to shut down - that is
handled synchronously - but instead, this waits for all connections to
close. Or, it would have, if it wasn't broken since it was introduced.

3.12 fixes the bug, which now causes a hang in our code. The fix is just
to remove the wait.

Signed-off-by: John Snow <jsnow@redhat.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>


--
Best regards,
Vladimir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]