qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] hw/sd/sdhci: Block Size Register bits [14:12] is lost


From: Michael Tokarev
Subject: Re: [PATCH v2] hw/sd/sdhci: Block Size Register bits [14:12] is lost
Date: Sat, 21 Oct 2023 10:36:12 +0300
User-agent: Mozilla Thunderbird

22.09.2023 05:03, Lu Gao:
Block Size Register bits [14:12] is SDMA Buffer Boundary, it is missed
in register write, but it is needed in SDMA transfer. e.g. it will be
used in sdhci_sdma_transfer_multi_blocks to calculate boundary_ variables.

Missing this field will cause wrong operation for different SDMA Buffer
Boundary settings.

Fixes: d7dfca0807 ("hw/sdhci: introduce standard SD host controller")
Fixes: dfba99f17f ("hw/sdhci: Fix DMA Transfer Block Size field")

Is this change stable-worthy?  Not understanding the implications, so
have to ask :)

Thanks,

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]