[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] qemu-img: rebase: stop when reaching EOF of old backing
From: |
Andrey Drobyshev |
Subject: |
Re: [PATCH 1/6] qemu-img: rebase: stop when reaching EOF of old backing file |
Date: |
Thu, 26 Oct 2023 11:16:14 +0300 |
User-agent: |
Mozilla Thunderbird |
On 10/26/23 09:32, Michael Tokarev wrote:
> 01.06.2023 22:28, Andrey Drobyshev via:
>> In case when we're rebasing within one backing chain, and when target
>> image
>> is larger than old backing file, bdrv_is_allocated_above() ends up
>> setting
>> *pnum = 0. As a result, target offset isn't getting incremented, and we
>> get stuck in an infinite for loop. Let's detect this case and proceed
>> further down the loop body, as the offsets beyond the old backing size
>> need
>> to be explicitly zeroed.
>
> Ping? Has this been forgotten? It's a few months already..
>
> /mjt
Hi Michael,
It's not forgotten, there's already v3 of this series and it's already
taken to the block branch by Kevin:
https://lists.nongnu.org/archive/html/qemu-block/2023-09/msg00593.html
Andrey