Re: [PATCH v4 01/10] blockjob: introduce block-job-change QMP command

[Eric Blake]

On Tue, Oct 31, 2023 at 02:54:22PM +0100, Fiona Ebner wrote:
> which will allow changing job-type-specific options after job
> creation.
> 
> In the JobVerbTable, the same allow bits as for set-speed are used,
> because set-speed can be considered an existing change command.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> 
> Changes in v4:
>     * Add note that change callback can be invoked before job coroutine
>       is running.
> 
>  blockdev.c                   | 14 ++++++++++++++
>  blockjob.c                   | 20 ++++++++++++++++++++
>  include/block/blockjob.h     | 11 +++++++++++
>  include/block/blockjob_int.h |  7 +++++++
>  job.c                        |  1 +
>  qapi/block-core.json         | 26 ++++++++++++++++++++++++++
>  qapi/job.json                |  4 +++-
>  7 files changed, 82 insertions(+), 1 deletion(-)
>

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org