[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 05/11] vfio: Avoid inspecting option QDict for rombar
From: |
Akihiko Odaki |
Subject: |
[PATCH v5 05/11] vfio: Avoid inspecting option QDict for rombar |
Date: |
Sun, 18 Feb 2024 13:56:10 +0900 |
Use pci_rom_bar_explicitly_enabled() to determine if rombar is explicitly
enabled.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/vfio/pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 4fa387f0430d..647f15b2a060 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -1012,7 +1012,6 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev)
{
uint32_t orig, size = cpu_to_le32((uint32_t)PCI_ROM_ADDRESS_MASK);
off_t offset = vdev->config_offset + PCI_ROM_ADDRESS;
- DeviceState *dev = DEVICE(vdev);
char *name;
int fd = vdev->vbasedev.fd;
@@ -1046,7 +1045,7 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev)
}
if (vfio_opt_rom_in_denylist(vdev)) {
- if (dev->opts && qdict_haskey(dev->opts, "rombar")) {
+ if (pci_rom_bar_explicitly_enabled(&vdev->pdev)) {
warn_report("Device at %s is known to cause system instability"
" issues during option rom execution",
vdev->vbasedev.name);
--
2.43.1
- [PATCH v5 00/11] hw/pci: SR-IOV related fixes and improvements, Akihiko Odaki, 2024/02/17
- [PATCH v5 01/11] hw/nvme: Use pcie_sriov_num_vfs(), Akihiko Odaki, 2024/02/17
- [PATCH v5 02/11] pcie_sriov: Validate NumVFs, Akihiko Odaki, 2024/02/17
- [PATCH v5 03/11] hw/pci: Use -1 as a default value for rombar, Akihiko Odaki, 2024/02/17
- [PATCH v5 04/11] hw/pci: Determine if rombar is explicitly enabled, Akihiko Odaki, 2024/02/17
- [PATCH v5 05/11] vfio: Avoid inspecting option QDict for rombar,
Akihiko Odaki <=
- [PATCH v5 06/11] hw/qdev: Remove opts member, Akihiko Odaki, 2024/02/17
- [PATCH v5 07/11] pcie_sriov: Reset SR-IOV extended capability, Akihiko Odaki, 2024/02/17
- [PATCH v5 08/11] pcie_sriov: Do not reset NumVFs after disabling VFs, Akihiko Odaki, 2024/02/17
- [PATCH v5 09/11] hw/pci: Always call pcie_sriov_pf_reset(), Akihiko Odaki, 2024/02/17
- [PATCH v5 10/11] hw/pci: Rename has_power to enabled, Akihiko Odaki, 2024/02/17
- [PATCH v5 11/11] pcie_sriov: Reuse SR-IOV VF device instances, Akihiko Odaki, 2024/02/17