[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/15] qtest/libqos: Reduce size_to_prdtl() declaration scope
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 07/15] qtest/libqos: Reduce size_to_prdtl() declaration scope |
Date: |
Tue, 2 Apr 2024 16:24:22 +0200 |
Since size_to_prdtl() is only used within ahci.c,
declare it statically. This removes the last use
of "inlined function with external linkage". See
previous commit and commit 9de9fa5cf2 for rationale.
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20240326171009.26696-4-philmd@linaro.org>
---
tests/qtest/libqos/ahci.h | 1 -
tests/qtest/libqos/ahci.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/qtest/libqos/ahci.h b/tests/qtest/libqos/ahci.h
index 48017864bf..a0487a1557 100644
--- a/tests/qtest/libqos/ahci.h
+++ b/tests/qtest/libqos/ahci.h
@@ -599,7 +599,6 @@ void ahci_port_check_cmd_sanity(AHCIQState *ahci,
AHCICommand *cmd);
/* Misc */
bool is_atapi(AHCIQState *ahci, uint8_t port);
-unsigned size_to_prdtl(unsigned bytes, unsigned bytes_per_prd);
/* Command: Macro level execution */
void ahci_guest_io(AHCIQState *ahci, uint8_t port, uint8_t ide_cmd,
diff --git a/tests/qtest/libqos/ahci.c b/tests/qtest/libqos/ahci.c
index a2c94c6e06..6d59c7551a 100644
--- a/tests/qtest/libqos/ahci.c
+++ b/tests/qtest/libqos/ahci.c
@@ -662,7 +662,7 @@ unsigned ahci_pick_cmd(AHCIQState *ahci, uint8_t port)
g_assert_not_reached();
}
-inline unsigned size_to_prdtl(unsigned bytes, unsigned bytes_per_prd)
+static unsigned size_to_prdtl(unsigned bytes, unsigned bytes_per_prd)
{
/* Each PRD can describe up to 4MiB */
g_assert_cmphex(bytes_per_prd, <=, 4096 * 1024);
--
2.41.0
- [PULL 00/15] Misc HW patches for 2024-04-02, Philippe Mathieu-Daudé, 2024/04/02
- [PULL 01/15] accel/tcg/plugin: Remove CONFIG_SOFTMMU_GATE definition, Philippe Mathieu-Daudé, 2024/04/02
- [PULL 02/15] gdbstub: Correct invalid mentions of 'softmmu' by 'system', Philippe Mathieu-Daudé, 2024/04/02
- [PULL 03/15] gdbstub/system: Rename 'user_ctx' argument as 'ctx', Philippe Mathieu-Daudé, 2024/04/02
- [PULL 04/15] target/ppc: Rename init_excp_4xx_softmmu() -> init_excp_4xx(), Philippe Mathieu-Daudé, 2024/04/02
- [PULL 05/15] hw/arm/smmu: Avoid using inlined functions with external linkage again, Philippe Mathieu-Daudé, 2024/04/02
- [PULL 06/15] accel/hvf: Un-inline hvf_arch_supports_guest_debug(), Philippe Mathieu-Daudé, 2024/04/02
- [PULL 07/15] qtest/libqos: Reduce size_to_prdtl() declaration scope,
Philippe Mathieu-Daudé <=
- [PULL 08/15] MAINTAINERS: Fix error-report.c entry, Philippe Mathieu-Daudé, 2024/04/02
- [PULL 09/15] hw/i386/pc: Restrict CXL to PCI-based machines, Philippe Mathieu-Daudé, 2024/04/02
- [PULL 10/15] block: Remove unnecessary NULL check in bdrv_pad_request(), Philippe Mathieu-Daudé, 2024/04/02
- [PULL 11/15] plugins: fix -Werror=maybe-uninitialized false-positive, Philippe Mathieu-Daudé, 2024/04/02
- [PULL 12/15] hw/nvme: fix -Werror=maybe-uninitialized, Philippe Mathieu-Daudé, 2024/04/02
- [PULL 13/15] gpio/pca955x: Update maintainer email address, Philippe Mathieu-Daudé, 2024/04/02
- [PULL 15/15] hw/net/virtio-net: fix qemu set used ring flag even vhost started, Philippe Mathieu-Daudé, 2024/04/02
- [PULL 14/15] hw/xen_evtchn: Initialize flush_kvm_routes, Philippe Mathieu-Daudé, 2024/04/02
- Re: [PULL 00/15] Misc HW patches for 2024-04-02, Peter Maydell, 2024/04/02