[Qemu-commits] [qemu/qemu] 0ee20e: ahci: Don't allow creating slave driv

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 0ee20e: ahci: Don't allow creating slave driv

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] 0ee20e: ahci: Don't allow creating slave drives
Date:	Wed, 08 May 2013 15:00:11 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 0ee20e665840d8a887c145b368ee121cb86a028e
      
https://github.com/qemu/qemu/commit/0ee20e665840d8a887c145b368ee121cb86a028e
  Author: Kevin Wolf <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M hw/ide/ahci.c
    M hw/ide/cmd646.c
    M hw/ide/internal.h
    M hw/ide/isa.c
    M hw/ide/macio.c
    M hw/ide/mmio.c
    M hw/ide/piix.c
    M hw/ide/qdev.c
    M hw/ide/via.c

  Log Message:
  -----------
  ahci: Don't allow creating slave drives

An IDE bus provided by AHCI can only take a single IDE drive. If you add
a drive as slave, qemu used to accept the command line but the device
wouldn't be actually usable. Catch the situation instead and error out.

Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 3bac85d33716d9024afb8a262a39032bc0bba3ed
      
https://github.com/qemu/qemu/commit/3bac85d33716d9024afb8a262a39032bc0bba3ed
  Author: Kevin Wolf <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M po/de_DE.po

  Log Message:
  -----------
  de_DE.po: Add missing leading spaces

Signed-off-by: Kevin Wolf <address@hidden>


  Commit: b39f96126549e2834152211a99919917423d2212
      
https://github.com/qemu/qemu/commit/b39f96126549e2834152211a99919917423d2212
  Author: Kevin Wolf <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M hw/ide/pci.c

  Log Message:
  -----------
  ide: Reset BMIDEA bit when the bus master is stopped

The device is supposed to reset the Bus Master IDE Active bit in the
status register when 0 is written to the Start/Stop Bus Master bit in
the command register.

In the common cases this happens automatically because bdrv_drain_all()
flushes the requests, but with a large PRDT it could remain set.

Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 9f0332b8cf27020d70be92f5e664466f0bcb84ec
      
https://github.com/qemu/qemu/commit/9f0332b8cf27020d70be92f5e664466f0bcb84ec
  Author: Kevin Wolf <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M tests/libqos/pci.c

  Log Message:
  -----------
  libqos/pci: Enable bus mastering

Signed-off-by: Kevin Wolf <address@hidden>


  Commit: acbe48013bf1eb9c9a435e76959f409584b35509
      
https://github.com/qemu/qemu/commit/acbe48013bf1eb9c9a435e76959f409584b35509
  Author: Kevin Wolf <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M tests/Makefile
    A tests/ide-test.c

  Log Message:
  -----------
  qtest: Add IDE test case

This adds a simple IDE test case and starts by verifying that IDENTIFY
can be successfully used and return the correct serial number, version
and the WCE flag is set for cache=writeback.

Signed-off-by: Kevin Wolf <address@hidden>


  Commit: b95739dcf5ae1dfa8cd5b2a5be27d427835e693b
      
https://github.com/qemu/qemu/commit/b95739dcf5ae1dfa8cd5b2a5be27d427835e693b
  Author: Kevin Wolf <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M tests/ide-test.c

  Log Message:
  -----------
  qtest/ide-test: Add simple DMA read/write test case

This tests that single sectors can be successfully written and correctly
read back.

Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 948eaed171e0dac541a59b42867f80881399bbd0
      
https://github.com/qemu/qemu/commit/948eaed171e0dac541a59b42867f80881399bbd0
  Author: Kevin Wolf <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M tests/ide-test.c

  Log Message:
  -----------
  qtest/ide-test: Test short and long PRDTs

This tests the behaviour of the DMA engine when the given PRDT contains
physical region descriptors for either more or less bytes than the
IDE request is for.

Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 1afe2726632a3344b92757bacdff57df49ef43e1
      
https://github.com/qemu/qemu/commit/1afe2726632a3344b92757bacdff57df49ef43e1
  Author: Fam Zheng <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M tests/qemu-iotests/042

  Log Message:
  -----------
  qemu-iotests: exclude vmdk for test 042

Zero sized disk is not supported by qemu vmdk driver, exclude vmdk from
the test script.

As tested on vmware-vdiskmanager and vmware workstation, zero sized disk
is not supported by vmware, either.

Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: dbcdd7cb04595cc0015f2dba6be751faa63fab00
      
https://github.com/qemu/qemu/commit/dbcdd7cb04595cc0015f2dba6be751faa63fab00
  Author: Fam Zheng <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M tests/qemu-iotests/043

  Log Message:
  -----------
  qemu-iotests: exclude vmdk and qcow from 043

043 tests recursive backing file by changing backing file. VMDK has not
implemented this yet, and qcow1 probably never will.

Signed-off-by: Fam Zheng <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 794d00f71d39e3d18eafade579b2ecb665d6d481
      
https://github.com/qemu/qemu/commit/794d00f71d39e3d18eafade579b2ecb665d6d481
  Author: Fam Zheng <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M tests/qemu-iotests/017
    M tests/qemu-iotests/017.out
    M tests/qemu-iotests/018
    M tests/qemu-iotests/018.out

  Log Message:
  -----------
  qemu-iotests: fix 017 018 for vmdk

017 and 018 use /bin/mv to move base img from t.IMGFMG to t.IMGFMT.base
after filling data, this is not enough for vmdk, when t.IMGFMT is only a
description text file who points to t-{flat,s001,f001,...}.IMGFMT as
data extent, so testing such subformats alway fails on them.

This patch use the trick of temprorily changing TEST_IMG to avoid using
/bin/mv.

Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 62c96360ae7f2c7a8b029277fbb7cb082fdef7fd
      
https://github.com/qemu/qemu/commit/62c96360ae7f2c7a8b029277fbb7cb082fdef7fd
  Author: Michael S. Tsirkin <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M hw/virtio/virtio-pci.c

  Log Message:
  -----------
  virtio-pci: fix level interrupts

mask notifiers are never called without msix,
so devices with backend masking like vhost don't work.
Call mask notifiers explicitly at
startup/cleanup to make it work.

Signed-off-by: Michael S. Tsirkin <address@hidden>
Tested-by: Alexander Graf <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 5f5a1318653c08e435cfa52f60b6a712815b659d
      
https://github.com/qemu/qemu/commit/5f5a1318653c08e435cfa52f60b6a712815b659d
  Author: Jason Wang <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: properly validate address before accessing config

There are several several issues in the current checking:

- The check was based on the minus of unsigned values which can overflow
- It was done after .{set|get}_config() which can lead crash when config_len
  is zero since vdev->config is NULL

Fix this by:

- Validate the address in virtio_pci_config_{read|write}() before
  .{set|get}_config
- Use addition instead minus to do the validation

Cc: Michael S. Tsirkin <address@hidden>
Cc: Petr Matousek <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
Acked-by: Petr Matousek <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: cad2b59c198340a636c5e015fb90e0326a1d3dd7
      
https://github.com/qemu/qemu/commit/cad2b59c198340a636c5e015fb90e0326a1d3dd7
  Author: Anthony Liguori <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M hw/ide/ahci.c
    M hw/ide/cmd646.c
    M hw/ide/internal.h
    M hw/ide/isa.c
    M hw/ide/macio.c
    M hw/ide/mmio.c
    M hw/ide/pci.c
    M hw/ide/piix.c
    M hw/ide/qdev.c
    M hw/ide/via.c
    M po/de_DE.po
    M tests/Makefile
    A tests/ide-test.c
    M tests/libqos/pci.c
    M tests/qemu-iotests/017
    M tests/qemu-iotests/017.out
    M tests/qemu-iotests/018
    M tests/qemu-iotests/018.out
    M tests/qemu-iotests/042
    M tests/qemu-iotests/043

  Log Message:
  -----------
  Merge remote-tracking branch 'kwolf/for-anthony' into staging

# By Kevin Wolf (7) and Fam Zheng (3)
# Via Kevin Wolf
* kwolf/for-anthony:
  qemu-iotests: fix 017 018 for vmdk
  qemu-iotests: exclude vmdk and qcow from 043
  qemu-iotests: exclude vmdk for test 042
  qtest/ide-test: Test short and long PRDTs
  qtest/ide-test: Add simple DMA read/write test case
  qtest: Add IDE test case
  libqos/pci: Enable bus mastering
  ide: Reset BMIDEA bit when the bus master is stopped
  de_DE.po: Add missing leading spaces
  ahci: Don't allow creating slave drives

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 47ec15cdd44877e553ed0bd0a16aea8a295dad62
      
https://github.com/qemu/qemu/commit/47ec15cdd44877e553ed0bd0a16aea8a295dad62
  Author: Anthony Liguori <address@hidden>
  Date:   2013-05-08 (Wed, 08 May 2013)

  Changed paths:
    M VERSION

  Log Message:
  -----------
  Update version for 1.5.0-rc1

Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d551d220c957...47ec15cdd448
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 0ee20e: ahci: Don't allow creating slave drives, GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu]
Next by Date: [Qemu-commits] [qemu/qemu] 38ebb3: target-i386: ROR r8/r16 imm instruction fix
Previous by thread: [Qemu-commits] [qemu/qemu] 36f48d: PPC: Depend behavior of cmp instructions only on i...
Next by thread: [Qemu-commits] [qemu/qemu] 38ebb3: target-i386: ROR r8/r16 imm instruction fix
Index(es):
- Date
- Thread