qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] bc5008: util/path: Use the GLib memory alloca

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] bc5008: util/path: Use the GLib memory allocation routines
Date: Mon, 25 Aug 2014 11:00:07 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: bc5008a832f95aae86efce844382e64d54da2146
      
https://github.com/qemu/qemu/commit/bc5008a832f95aae86efce844382e64d54da2146
  Author: zhanghailiang <address@hidden>
  Date:   2014-08-24 (Sun, 24 Aug 2014)

  Changed paths:
    M util/path.c

  Log Message:
  -----------
  util/path: Use the GLib memory allocation routines

In this file, we don't check the return value of malloc/strdup/realloc which 
may fail.
Instead of using these routines, we use the GLib memory APIs 
g_malloc/g_strdup/g_realloc.
They will exit on allocation failure, so there is no need to test for failure,
which would be fine for setup.

Signed-off-by: zhanghailiang <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: d70724cec84ff99ffc7f70dd567466acf228b389
      
https://github.com/qemu/qemu/commit/d70724cec84ff99ffc7f70dd567466acf228b389
  Author: zhanghailiang <address@hidden>
  Date:   2014-08-24 (Sun, 24 Aug 2014)

  Changed paths:
    M tcg/tcg.c

  Log Message:
  -----------
  tcg: dump op count into qemu log

fopen() may fail and it does not check its return vaule here,
it is better to dump op count to the normal log file.

Signed-off-by: Li Liu <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: c39a28a43d95a3dcb339bdc2865e953a79f01378
      
https://github.com/qemu/qemu/commit/c39a28a43d95a3dcb339bdc2865e953a79f01378
  Author: zhanghailiang <address@hidden>
  Date:   2014-08-24 (Sun, 24 Aug 2014)

  Changed paths:
    M tests/bios-tables-test.c

  Log Message:
  -----------
  tests/bios-tables-test: check the value returned by fopen()

The function fopen() may fail, so check its return value.

Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Li Liu <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: f55f8852675f1ece8739b5f89aeda8418c483367
      
https://github.com/qemu/qemu/commit/f55f8852675f1ece8739b5f89aeda8418c483367
  Author: Peter Crosthwaite <address@hidden>
  Date:   2014-08-24 (Sun, 24 Aug 2014)

  Changed paths:
    M hw/microblaze/petalogix_ml605_mmu.c

  Log Message:
  -----------
  microblaze: ml605: Get rid of ddr_base variable

It's a constant based on a macro. Just use the macro in place.

Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 6a07a695b0a8bf8638d28d06909a100c854cfc73
      
https://github.com/qemu/qemu/commit/6a07a695b0a8bf8638d28d06909a100c854cfc73
  Author: Peter Crosthwaite <address@hidden>
  Date:   2014-08-24 (Sun, 24 Aug 2014)

  Changed paths:
    M hw/dma/xilinx_axidma.c

  Log Message:
  -----------
  dma: axidma: Variablise repeated s->streams[i] sub-expr

This have 6 inline usages. Make it a bit more readable by using a local
variable.

Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 58ab9e680731ffd1793a7957ab8523f1dca18d05
      
https://github.com/qemu/qemu/commit/58ab9e680731ffd1793a7957ab8523f1dca18d05
  Author: Liming Wang <address@hidden>
  Date:   2014-08-24 (Sun, 24 Aug 2014)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: no need to mkdir QMP

commit 7537fe04 QMP: QMP/ -> docs/qmp/

Above commit has moved last QMP files to docs/qmp and it's not necessary
to create QMP directory. So remove it from configure.

Signed-off-by: Liming Wang <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 2fd5d864099dd38b43b595e9e3375dad2f76049b
      
https://github.com/qemu/qemu/commit/2fd5d864099dd38b43b595e9e3375dad2f76049b
  Author: zhanghailiang <address@hidden>
  Date:   2014-08-24 (Sun, 24 Aug 2014)

  Changed paths:
    M slirp/misc.c
    M slirp/misc.h
    M slirp/slirp_config.h

  Log Message:
  -----------
  slirp/misc: Use the GLib memory allocation APIs

Here we don't check the return value of malloc() which may fail.
Use the g_new() instead, which will abort the program when
there is not enough memory.

Also, use g_strdup instead of strdup and remove the unnecessary
strdup function.

Signed-off-by: zhanghailiang <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Benoît Canet <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: bcc55f327c571295193880110c048b463bce6677
      
https://github.com/qemu/qemu/commit/bcc55f327c571295193880110c048b463bce6677
  Author: Stefan Weil <address@hidden>
  Date:   2014-08-24 (Sun, 24 Aug 2014)

  Changed paths:
    M po/Makefile

  Log Message:
  -----------
  po: Fix Makefile rules for in-tree builds without configuration

Adding 'update' to the phony targets fixes this error:

$ LANG=C make -C po update
make: Entering directory `/qemu/po'
  LINK  update
/qemu/po/de_DE.po: file not recognized: File format not recognized
collect2: error: ld returned 1 exit status
make: *** [update] Error 1
make: Leaving directory `/qemu/po'

Some other phony targets (build, install) were also added, and the
existing .PHONY statement was moved to a more prominent position at
the beginning of the Makefile.

The patch also fixes a 2nd bug. The default target should be 'all',
but instead 'modules' (from rules.mak) was the default. Fix this by
adding 'all' as a target before any include statement.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 680dfde91981516942ec557ef1c27753db24cbe8
      
https://github.com/qemu/qemu/commit/680dfde91981516942ec557ef1c27753db24cbe8
  Author: zhanghailiang <address@hidden>
  Date:   2014-08-24 (Sun, 24 Aug 2014)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: fix file descriptor leaks

Handle variable "fd_orig" going out of scope leaks the handle.

Signed-off-by: zhanghailiang <address@hidden>
Reviewed-by: Gonglei <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: d072cdf3baeab6a190aa9f2f64a8702744f83d29
      
https://github.com/qemu/qemu/commit/d072cdf3baeab6a190aa9f2f64a8702744f83d29
  Author: Stefan Weil <address@hidden>
  Date:   2014-08-24 (Sun, 24 Aug 2014)

  Changed paths:
    M libdecnumber/decNumber.c

  Log Message:
  -----------
  libdecnumber: Fix warnings from smatch (missing static, boolean operations)

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 40a87c6c9b11ef9c14e0301f76abf0eb2582f08e
      
https://github.com/qemu/qemu/commit/40a87c6c9b11ef9c14e0301f76abf0eb2582f08e
  Author: Ben Draper <address@hidden>
  Date:   2014-08-24 (Sun, 24 Aug 2014)

  Changed paths:
    M hw/net/vmxnet3.c

  Log Message:
  -----------
  vmxnet3: Pad short frames to minimum size (60 bytes)

When running VMware ESXi under qemu-kvm the guest discards frames
that are too short. Short ARP Requests will be dropped, this prevents
guests on the same bridge as VMware ESXi from communicating. This patch
simply adds the padding on the network device itself.

Signed-off-by: Ben Draper <address@hidden>
Reviewed-by: Dmitry Fleytman <address@hidden>
Cc: address@hidden
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 3dd359c2d34c6abf385d58da863f337b39702585
      
https://github.com/qemu/qemu/commit/3dd359c2d34c6abf385d58da863f337b39702585
  Author: Peter Maydell <address@hidden>
  Date:   2014-08-25 (Mon, 25 Aug 2014)

  Changed paths:
    M configure
    M hw/dma/xilinx_axidma.c
    M hw/microblaze/petalogix_ml605_mmu.c
    M hw/net/vmxnet3.c
    M libdecnumber/decNumber.c
    M linux-user/syscall.c
    M po/Makefile
    M slirp/misc.c
    M slirp/misc.h
    M slirp/slirp_config.h
    M tcg/tcg.c
    M tests/bios-tables-test.c
    M util/path.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-08-24' 
into staging

trivial patches for 2014-08-24

# gpg: Signature made Sun 24 Aug 2014 14:28:49 BST using RSA key ID A4C3D7DB
# gpg: Good signature from "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044 65C5
#      Subkey fingerprint: 6F67 E18E 7C91 C5B1 5514  66A7 BEE5 9D74 A4C3 D7DB

* remotes/mjt/tags/trivial-patches-2014-08-24:
  vmxnet3: Pad short frames to minimum size (60 bytes)
  libdecnumber: Fix warnings from smatch (missing static, boolean operations)
  linux-user: fix file descriptor leaks
  po: Fix Makefile rules for in-tree builds without configuration
  slirp/misc: Use the GLib memory allocation APIs
  configure: no need to mkdir QMP
  dma: axidma: Variablise repeated s->streams[i] sub-expr
  microblaze: ml605: Get rid of ddr_base variable
  tests/bios-tables-test: check the value returned by fopen()
  tcg: dump op count into qemu log
  util/path: Use the GLib memory allocation routines

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/33886ebeec0c...3dd359c2d34c
reply via email to
[Prev in Thread] Current Thread [Next in Thread]