[Qemu-commits] [qemu/qemu] 2472b6: gdbstub: Allow target CPUs to specify watchpoint S...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2472b6c07bb50179019589af1c22f43935ab7f5c
      
https://github.com/qemu/qemu/commit/2472b6c07bb50179019589af1c22f43935ab7f5c
  Author: Peter Maydell <address@hidden>
  Date:   2014-10-06 (Mon, 06 Oct 2014)

  Changed paths:
    M gdbstub.c
    M include/qom/cpu.h
    M target-arm/cpu.c
    M target-cris/cpu.c
    M target-lm32/cpu.c
    M target-mips/cpu.c
    M target-xtensa/cpu.c

  Log Message:
  -----------
  gdbstub: Allow target CPUs to specify watchpoint STOP_BEFORE_ACCESS flag

GDB assumes that watchpoint set via the gdbstub remote protocol will
behave in the same way as hardware watchpoints for the target. In
particular, whether the CPU stops with the PC before or after the insn
which triggers the watchpoint is target dependent. Allow guest CPU
code to specify which behaviour to use. This fixes a bug where with
guest CPUs which stop before the accessing insn GDB would manually
step forward over what it thought was the insn and end up one insn
further forward than it should be.

We set this flag for the CPU architectures which set
gdbarch_have_nonsteppable_watchpoint in gdb 7.7:
ARM, CRIS, LM32, MIPS and Xtensa.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
Tested-by: Max Filippov <address@hidden>
Tested-by: Edgar E. Iglesias <address@hidden>
Tested-by: Michael Walle <address@hidden> (for lm32)
Message-id: address@hidden