[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 7a8919: net/slirp: fix memory leak
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] 7a8919: net/slirp: fix memory leak |
Date: |
Fri, 21 Nov 2014 07:30:06 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 7a8919dc29a9f46dcadd950c2aa1acf74f28974d
https://github.com/qemu/qemu/commit/7a8919dc29a9f46dcadd950c2aa1acf74f28974d
Author: Gonglei <address@hidden>
Date: 2014-11-21 (Fri, 21 Nov 2014)
Changed paths:
M net/slirp.c
Log Message:
-----------
net/slirp: fix memory leak
commit b412eb61 introduce 'cmd:' target for guestfwd,
and fwd don't be used in this scenario, and will leak
memory in true branch with 'cmd:'. Let's allocate memory
for fwd variable just in else statement.
Cc: Alexander Graf <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Jason Wang <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Commit: 8db804ac412010fc96397c2d67ee6417eccd9d34
https://github.com/qemu/qemu/commit/8db804ac412010fc96397c2d67ee6417eccd9d34
Author: Gonglei <address@hidden>
Date: 2014-11-21 (Fri, 21 Nov 2014)
Changed paths:
M net/socket.c
Log Message:
-----------
net/socket: fix Uninitialized scalar variable
If is_connected parameter is false, the saddr
variable will no initialize. Coverity report:
uninit_use: Using uninitialized value saddr.sin_port.
We don't need add saddr information to nc->info_str
when is_connected is false.
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Jason Wang <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Commit: 7b50d00911ddd6d56a766ac5671e47304c20a21b
https://github.com/qemu/qemu/commit/7b50d00911ddd6d56a766ac5671e47304c20a21b
Author: Gonglei <address@hidden>
Date: 2014-11-21 (Fri, 21 Nov 2014)
Changed paths:
M hw/net/pcnet.c
Log Message:
-----------
pcnet: fix Negative array index read
s->xmit_pos maybe assigned to a negative value (-1),
but in this branch variable s->xmit_pos as an index to
array s->buffer. Let's add a check for s->xmit_pos.
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Jason Wang <address@hidden>
Reviewed-by: Jason Wang <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Commit: b0af844007841609cc11fab58f838bd105cbe144
https://github.com/qemu/qemu/commit/b0af844007841609cc11fab58f838bd105cbe144
Author: Gonglei <address@hidden>
Date: 2014-11-21 (Fri, 21 Nov 2014)
Changed paths:
M hw/net/rtl8139.c
Log Message:
-----------
rtl8139: fix Pointer to local outside scope
Coverity spot:
Assigning: iov = struct iovec [3]({{buf, 12UL},
{(void *)dot1q_buf, 4UL},
{buf + 12, size - 12}})
(address of temporary variable of type struct iovec [3]).
out_of_scope: Temporary variable of type struct iovec [3] goes out of scope.
Pointer to local outside scope (RETURN_LOCAL)
use_invalid:
Using iov, which points to an out-of-scope temporary variable of type struct
iovec [3].
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Jason Wang <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Commit: 0e88f478508b566152c6681f4889ed9830a2c0a5
https://github.com/qemu/qemu/commit/0e88f478508b566152c6681f4889ed9830a2c0a5
Author: Peter Maydell <address@hidden>
Date: 2014-11-21 (Fri, 21 Nov 2014)
Changed paths:
M hw/net/pcnet.c
M hw/net/rtl8139.c
M net/slirp.c
M net/socket.c
Log Message:
-----------
Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into
staging
# gpg: Signature made Fri 21 Nov 2014 11:12:37 GMT using RSA key ID 81AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg: aka "Stefan Hajnoczi <address@hidden>"
* remotes/stefanha/tags/net-pull-request:
rtl8139: fix Pointer to local outside scope
pcnet: fix Negative array index read
net/socket: fix Uninitialized scalar variable
net/slirp: fix memory leak
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/a00c11733857...0e88f478508b
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 7a8919: net/slirp: fix memory leak,
GitHub <=