[Qemu-commits] [qemu/qemu] f342cc: qemu-ga: Make QGA VSS provider service run only wh...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f342cc93ec918d684e8a6f6e646551a9c7fbc019
      
https://github.com/qemu/qemu/commit/f342cc93ec918d684e8a6f6e646551a9c7fbc019
  Author: Sameeh Jubran <address@hidden>
  Date:   2017-04-26 (Wed, 26 Apr 2017)

  Changed paths:
    M qga/vss-win32/install.cpp
    A qga/vss-win32/install.h
    M qga/vss-win32/requester.cpp

  Log Message:
  -----------
  qemu-ga: Make QGA VSS provider service run only when needed

Currently the service runs in background on boot even though it is not
needed and once it is running it never stops. The service needs to be
running only during freeze operation and it should be stopped after
executing thaw.

Signed-off-by: Sameeh Jubran <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 54858553def1879a3b0781529fb12a028ba36713
      
https://github.com/qemu/qemu/commit/54858553def1879a3b0781529fb12a028ba36713
  Author: Sameeh Jubran <address@hidden>
  Date:   2017-04-26 (Wed, 26 Apr 2017)

  Changed paths:
    M qga/commands-win32.c

  Log Message:
  -----------
  qga-win: Enable 'can-offline' field in 'guest-get-vcpus' reply

The QGA schema states:

@can-offline: Whether offlining the VCPU is possible. This member
         is always filled in by the guest agent when the structure
         is returned, and always ignored on input (hence it can be
         omitted then).

Currently 'can-offline' is missing entirely from the reply. This causes
errors in libvirt which is expecting the reply to be compliant with the
schema docs.

BZ#1438735: https://bugzilla.redhat.com/show_bug.cgi?id=1438735

Signed-off-by: Sameeh Jubran <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Cc: address@hidden
Signed-off-by: Michael Roth <address@hidden>


  Commit: 94d81ae896810beafa60c85b88e991daa986e1fc
      
https://github.com/qemu/qemu/commit/94d81ae896810beafa60c85b88e991daa986e1fc
  Author: Sameeh Jubran <address@hidden>
  Date:   2017-04-26 (Wed, 26 Apr 2017)

  Changed paths:
    M qga/main.c
    M qga/vss-win32.h
    M qga/vss-win32/vss-common.h
    A qga/vss-win32/vss-handles.h

  Log Message:
  -----------
  qga-win: Fix a bug where qemu-ga service is stuck during stop operation

After triggering a freeze command without any following thaw command,
qemu-ga will not respond to stop operation. This behaviour is wanted on Linux
as there is no time limit for a freeze command and we want to prevent
quitting in the middle of freeze, on the other hand on Windows the time
limit for freeze is 10 seconds, so we should wait for the timeout, thaw
the file system and quit.

Signed-off-by: Sameeh Jubran <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 15296053378462e996032d9f50d62515f2230681
      
https://github.com/qemu/qemu/commit/15296053378462e996032d9f50d62515f2230681
  Author: Sameeh Jubran <address@hidden>
  Date:   2017-04-26 (Wed, 26 Apr 2017)

  Changed paths:
    M qga/vss-win32/provider.cpp

  Log Message:
  -----------
  qga-win: Fix Event Viewer errors caused by qemu-ga

When the command "guest-fsfreeze-freeze" is executed it causes
the VSS service to log the error below in the Event Viewer. This
error is caused by an issue in the function "CommitSnapshots" in
provider.cpp:

* When VSS_TIMEOUT_MSEC expires the funtion returns E_ABORT. This causes
the error #12293.

|event id|                           error                               |
* 12293  : Volume Shadow Copy Service error: Error calling a routine on a
     Shadow Copy Provider {00000000-0000-0000-0000-000000000000}.
     Routine details CommitSnapshots [hr = 0x80004004, Operation
     aborted.

Signed-off-by: Sameeh Jubran <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 0a3d197a71b0508f5ca066488fbbbe45a61c44fe
      
https://github.com/qemu/qemu/commit/0a3d197a71b0508f5ca066488fbbbe45a61c44fe
  Author: Vinzenz Feenstra <address@hidden>
  Date:   2017-04-26 (Wed, 26 Apr 2017)

  Changed paths:
    M qga/commands.c
    M qga/qapi-schema.json

  Log Message:
  -----------
  qga: Add 'guest-get-host-name' command

Retrieving the guest host name is a very useful feature for virtual management
systems. This information can help to have more user friendly VM access
details, instead of an IP there would be the host name. Also the host name
reported can be used to have automated checks for valid SSL certificates.

virsh # qemu-agent-command F25 '{ "execute": "guest-get-host-name" }'
{"return":{"host-name":"F25.lab.evilissimo.net"}}

Signed-off-by: Vinzenz Feenstra <address@hidden>
* minor whitespace fix-ups
Signed-off-by: Michael Roth <address@hidden>


  Commit: 1dbfbc17fe783e34644daf4abbb8f4e17344abcd
      
https://github.com/qemu/qemu/commit/1dbfbc17fe783e34644daf4abbb8f4e17344abcd
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-04-26 (Wed, 26 Apr 2017)

  Changed paths:
    M qga/qapi-schema.json

  Log Message:
  -----------
  qga: improve fsfreeze documentations

Some users find the fsfreeze behaviour confusing. Add some notes about
invalid mount points and Windows usage.

Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1436976

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Vinzenz Feenstra <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 161a56a9065feb6fa2f69cec6237a5c4e714b9d3
      
https://github.com/qemu/qemu/commit/161a56a9065feb6fa2f69cec6237a5c4e714b9d3
  Author: Vinzenz Feenstra <address@hidden>
  Date:   2017-04-26 (Wed, 26 Apr 2017)

  Changed paths:
    M configure
    M include/glib-compat.h
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/qapi-schema.json

  Log Message:
  -----------
  qga: Add 'guest-get-users' command

A command that will list all currently logged in users, and the time
since when they are logged in.

Examples:

virsh # qemu-agent-command F25 '{ "execute": "guest-get-users" }'
{"return":[{"login-time":1490622289.903835,"user":"root"}]}

virsh # qemu-agent-command Win2k12r2 '{ "execute": "guest-get-users" }'
{"return":[{"login-time":1490351044.670552,"domain":"LADIDA",
"user":"Administrator"}]}

Signed-off-by: Vinzenz Feenstra <address@hidden>
* make g_hash_table_contains compat func inline to avoid
  unused warnings
Signed-off-by: Michael Roth <address@hidden>


  Commit: 53c58e64d0a27c59d763778faa2b5a522c544719
      
https://github.com/qemu/qemu/commit/53c58e64d0a27c59d763778faa2b5a522c544719
  Author: Vinzenz Feenstra <address@hidden>
  Date:   2017-04-27 (Thu, 27 Apr 2017)

  Changed paths:
    M qga/commands.c
    M qga/qapi-schema.json

  Log Message:
  -----------
  qga: Add `guest-get-timezone` command

Adds a new command `guest-get-timezone` reporting the currently
configured timezone on the system. The information on what timezone is
currently is configured is useful in case of Windows VMs where the
offset of the hardware clock is required to have the same offset. This
can be used for management systems like `oVirt` to detect the timezone
difference and warn administrators of the misconfiguration.

Signed-off-by: Vinzenz Feenstra <address@hidden>
Reviewed-by: Sameeh Jubran <address@hidden>
Tested-by: Sameeh Jubran <address@hidden>
* moved stub implementation to end of function for consistency
* document that timezone names are for informational use only.
Signed-off-by: Michael Roth <address@hidden>


  Commit: 7ad691ec988dd0ca1c3674018f6aede8ed18128b
      
https://github.com/qemu/qemu/commit/7ad691ec988dd0ca1c3674018f6aede8ed18128b
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2017-04-28 (Fri, 28 Apr 2017)

  Changed paths:
    M configure
    M include/glib-compat.h
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/commands.c
    M qga/main.c
    M qga/qapi-schema.json
    M qga/vss-win32.h
    M qga/vss-win32/install.cpp
    A qga/vss-win32/install.h
    M qga/vss-win32/provider.cpp
    M qga/vss-win32/requester.cpp
    M qga/vss-win32/vss-common.h
    A qga/vss-win32/vss-handles.h

  Log Message:
  -----------
  Merge remote-tracking branch 'mdroth/tags/qga-pull-2017-04-25-v2-tag' into 
staging

qemu-ga patch queue

* new commands: guest-get-timezone, guest-get-users, guest-get-host-name
* fix hang on w32 when stopping qemu-ga service while fs frozen
* fix missing setting of can-offline in guest-get-vcpus
* make qemu-ga VSS w32 service on-demand rather than on-startup
* fix unecessary errors to EventLog on w32
* improvements to fsfreeze documentation

v2:
 * document 'zone' field of guest-get-timezone as informational-only
   (Daniel, Eric)
 * fix build error for glib < 2.32 (Peter)

# gpg: Signature made Thu 27 Apr 2017 06:43:42 AM BST
# gpg:                using RSA key 0x3353C9CEF108B584
# gpg: Good signature from "Michael Roth <address@hidden>"
# gpg:                 aka "Michael Roth <address@hidden>"
# gpg:                 aka "Michael Roth <address@hidden>"
# Primary key fingerprint: CEAC C9E1 5534 EBAB B82D  3FA0 3353 C9CE F108 B584

* mdroth/tags/qga-pull-2017-04-25-v2-tag:
  qga: Add `guest-get-timezone` command
  qga: Add 'guest-get-users' command
  qga: improve fsfreeze documentations
  qga: Add 'guest-get-host-name' command
  qga-win: Fix Event Viewer errors caused by qemu-ga
  qga-win: Fix a bug where qemu-ga service is stuck during stop operation
  qga-win: Enable 'can-offline' field in 'guest-get-vcpus' reply
  qemu-ga: Make QGA VSS provider service run only when needed

Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 64a6047d54c66052bcf35b163fbdcd1f2a27f24f
      
https://github.com/qemu/qemu/commit/64a6047d54c66052bcf35b163fbdcd1f2a27f24f
  Author: Greg Kurz <address@hidden>
  Date:   2017-04-28 (Fri, 28 Apr 2017)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: fix trace backend list for out-of-tree builds

Since commit "c53eeaf75a04 configure: eliminate Python dependency for
--help", configure --help fails to produce the list of available trace
backends if invoked out-of-tree. It also spits the following error:

grep: scripts/tracetool/backend/*.py: No such file or directory

This patch simply adds the missing $source_path to fix it.

Signed-off-by: Greg Kurz <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 38bb54f323bf7c83496b6a044cfd28896e997a00
      
https://github.com/qemu/qemu/commit/38bb54f323bf7c83496b6a044cfd28896e997a00
  Author: Markus Armbruster <address@hidden>
  Date:   2017-04-28 (Fri, 28 Apr 2017)

  Changed paths:
    M migration/colo.c
    M monitor.c

  Log Message:
  -----------
  replication: Make --disable-replication compile again

Broken in commit daa33c5.

Cc: address@hidden
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Zhang Chen <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


Compare: https://github.com/qemu/qemu/compare/81b2d5ceb0cf...38bb54f323bf