[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 403a90: 9pfs: avoid sign conversion error sim
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] 403a90: 9pfs: avoid sign conversion error simplifying the ... |
Date: |
Tue, 05 Sep 2017 09:42:45 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 403a905b03d48187df1e1392bfa3e303eeefe892
https://github.com/qemu/qemu/commit/403a905b03d48187df1e1392bfa3e303eeefe892
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2017-09-05 (Tue, 05 Sep 2017)
Changed paths:
M hw/9pfs/9p.c
Log Message:
-----------
9pfs: avoid sign conversion error simplifying the code
(note this is how other functions also handle the errors).
hw/9pfs/9p.c:948:18: warning: Loss of sign in implicit conversion
offset = err;
^~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Greg Kurz <address@hidden>
Commit: 3c08f4a4335c325295d738d4090665b8617ab599
https://github.com/qemu/qemu/commit/3c08f4a4335c325295d738d4090665b8617ab599
Author: ZhiPeng Lu <address@hidden>
Date: 2017-09-05 (Tue, 05 Sep 2017)
Changed paths:
M fsdev/virtfs-proxy-helper.c
Log Message:
-----------
fsdev: fix memory leak in main()
@rpath and @sock_name are not freed and leaked.
[groug, not really leaked since the program exits just after that. But it
is always good practice to free allocated memory]
Signed-off-by: Zhipeng Lu <address@hidden>
Signed-off-by: Greg Kurz <address@hidden>
Commit: aa5e85a10846636165592c5a46d797c100c68529
https://github.com/qemu/qemu/commit/aa5e85a10846636165592c5a46d797c100c68529
Author: Greg Kurz <address@hidden>
Date: 2017-09-05 (Tue, 05 Sep 2017)
Changed paths:
M hw/9pfs/9p-local.c
Log Message:
-----------
9pfs: local: clarify fchmodat_nofollow() implementation
Since fchmodat(2) on Linux doesn't support AT_SYMLINK_NOFOLLOW, we have to
implement it using workarounds. There are two different ways, depending on
whether the system supports O_PATH or not.
In the case O_PATH is supported, we rely on the behavhior of openat(2)
when passing O_NOFOLLOW | O_PATH and the file is a symbolic link. Even
if openat_file() already adds O_NOFOLLOW to the flags, this patch makes
it explicit that we need both creation flags to obtain the expected
behavior.
This is only cleanup, no functional change.
Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: 32b6943699948f7adc35ada233fbd25daffad5e9
https://github.com/qemu/qemu/commit/32b6943699948f7adc35ada233fbd25daffad5e9
Author: Greg Kurz <address@hidden>
Date: 2017-09-05 (Tue, 05 Sep 2017)
Changed paths:
M vl.c
Log Message:
-----------
virtfs: error out gracefully when mandatory suboptions are missing
We internally convert -virtfs to -fsdev/-device. If the user doesn't
provide the path or security_model suboptions, and the fsdev backend
requires them, we hit an assertion when populating the internal -fsdev
option:
util/qemu-option.c:547: opt_set: Assertion `opt->str' failed.
Aborted (core dumped)
Let's test the suboption presence on the command line before trying
to set it in the internal -fsdev option, and let the backend code
error out gracefully (ie, like it already does when the user passes
-fsdev on the command line).
Reported-by: Thomas Huth <address@hidden>
Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Commit: f5f3a7f4cca1af75770f718ad918a49a3c994604
https://github.com/qemu/qemu/commit/f5f3a7f4cca1af75770f718ad918a49a3c994604
Author: Peter Maydell <address@hidden>
Date: 2017-09-05 (Tue, 05 Sep 2017)
Changed paths:
M fsdev/virtfs-proxy-helper.c
M hw/9pfs/9p-local.c
M hw/9pfs/9p.c
M vl.c
Log Message:
-----------
Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging
Some trivial fixes/cleanup and a fix to cause QEMU to error out gracefully
instead of aborting.
# gpg: Signature made Tue 05 Sep 2017 16:57:19 BST
# gpg: using DSA key 0x02FC3AEB0101DBC2
# gpg: Good signature from "Greg Kurz <address@hidden>"
# gpg: aka "Greg Kurz <address@hidden>"
# gpg: aka "Greg Kurz <address@hidden>"
# gpg: aka "Gregory Kurz (Groug) <address@hidden>"
# gpg: aka "[jpeg image of size 3330]"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg: There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 2BD4 3B44 535E C0A7 9894 DBA2 02FC 3AEB 0101 DBC2
* remotes/gkurz/tags/for-upstream:
virtfs: error out gracefully when mandatory suboptions are missing
9pfs: local: clarify fchmodat_nofollow() implementation
fsdev: fix memory leak in main()
9pfs: avoid sign conversion error simplifying the code
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/6bbd7e2728f4...f5f3a7f4cca1
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 403a90: 9pfs: avoid sign conversion error simplifying the ...,
GitHub <=