qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 56207d: hbitmap: add next_zero function

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 56207d: hbitmap: add next_zero function
Date: Tue, 19 Dec 2017 11:10:44 -0800 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 56207df55ea546f3e72578a5920e68a346440b1a
      
https://github.com/qemu/qemu/commit/56207df55ea546f3e72578a5920e68a346440b1a
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M block/dirty-bitmap.c
    M include/block/dirty-bitmap.h
    M include/qemu/hbitmap.h
    M tests/test-hbitmap.c
    M util/hbitmap.c

  Log Message:
  -----------
  hbitmap: add next_zero function

The function searches for next zero bit.
Also add interface for BdrvDirtyBitmap and unit test.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>


  Commit: a193b0f0a8d7735f4eb2ff863fd0902a5fa5eec6
      
https://github.com/qemu/qemu/commit/a193b0f0a8d7735f4eb2ff863fd0902a5fa5eec6
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M block/backup.c

  Log Message:
  -----------
  backup: move from done_bitmap to copy_bitmap

Use HBitmap copy_bitmap instead of done_bitmap. This is needed to
improve incremental backup in following patches and to unify backup
loop for full/incremental modes in future patches.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>


  Commit: 8cc6dc6215fa2a278fd853a2caca172e43c6263e
      
https://github.com/qemu/qemu/commit/8cc6dc6215fa2a278fd853a2caca172e43c6263e
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M block/backup.c

  Log Message:
  -----------
  backup: init copy_bitmap from sync_bitmap for incremental

We should not copy non-dirty clusters in write notifiers. So,
initialize copy_bitmap from sync_bitmap.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>


  Commit: 085bd08e6f32f0d96885ff8e0fa2896c2fabed50
      
https://github.com/qemu/qemu/commit/085bd08e6f32f0d96885ff8e0fa2896c2fabed50
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M block/backup.c

  Log Message:
  -----------
  backup: simplify non-dirty bits progress processing

Set fake progress for non-dirty clusters in copy_bitmap initialization,
to. It simplifies code and allows further refactoring.

This patch changes user's view of backup progress, but formally it
doesn't changed: progress hops are just moved to the beginning.

Actually it's just a point of view: when do we actually skip clusters?
We can say in the very beginning, that we skip these clusters and do
not think about them later.

Of course, if go through disk sequentially, it's logical to say, that
we skip clusters between copied portions to the left and to the right
of them. But even now copying progress is not sequential because of
write notifiers. Future patches will introduce new backup architecture
which will do copying in several coroutines in parallel, so it will
make no sense to publish fake progress by parts in parallel with
other copying requests.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>


  Commit: 53f1c8794f2c1aea4d2888a3ac4e1b3b8b8b9777
      
https://github.com/qemu/qemu/commit/53f1c8794f2c1aea4d2888a3ac4e1b3b8b8b9777
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M block/backup.c

  Log Message:
  -----------
  backup: use copy_bitmap in incremental backup

We can use copy_bitmap instead of sync_bitmap. copy_bitmap is
initialized from sync_bitmap and it is more informative: we will not try
to process data, that is already in progress (by write notifier).

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>


  Commit: aa9ef2e65bed6a8f1709e0523fc856ec08beb657
      
https://github.com/qemu/qemu/commit/aa9ef2e65bed6a8f1709e0523fc856ec08beb657
  Author: John Snow <address@hidden>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M blockjob.c

  Log Message:
  -----------
  blockjob: kick jobs on set-speed

If users set an unreasonably low speed (like one byte per second), the
calculated delay may exceed many hours. While we like to punish users
for asking for stupid things, we do also like to allow users to correct
their wicked ways.

When a user provides a new speed, kick the job to allow it to recalculate
its delay.

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>


  Commit: ac90dad94b5b1eda18a9a86c739c249d851cd35c
      
https://github.com/qemu/qemu/commit/ac90dad94b5b1eda18a9a86c739c249d851cd35c
  Author: Jeff Cody <address@hidden>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M block/sheepdog.c

  Log Message:
  -----------
  block/sheepdog: remove spurious NULL check

'tag' is already checked in the lines immediately preceding this check,
and set to non-NULL if NULL.  No need to check again, it hasn't changed.

Signed-off-by: Jeff Cody <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Darren Kenny <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>


  Commit: d507c5f682d23a60a356a081557ceb34ea0d2669
      
https://github.com/qemu/qemu/commit/d507c5f682d23a60a356a081557ceb34ea0d2669
  Author: Jeff Cody <address@hidden>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M block/sheepdog.c

  Log Message:
  -----------
  block/sheepdog: code beautification

No functional changes, just whitespace manipulation.

Signed-off-by: Jeff Cody <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Darren Kenny <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>


  Commit: 2d25964d1831c99d54981e8b615eba5dd6a63e36
      
https://github.com/qemu/qemu/commit/2d25964d1831c99d54981e8b615eba5dd6a63e36
  Author: Jeff Cody <address@hidden>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M block/curl.c

  Log Message:
  -----------
  block/curl: check error return of curl_global_init()

If curl_global_init() fails, per the documentation no other curl
functions may be called, so make sure to check the return value.

Also, some minor changes to the initialization latch variable 'inited':

- Make it static in the file, for clarity
- Change the name for clarity
- Make it a bool

Signed-off-by: Jeff Cody <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Richard W.M. Jones <address@hidden>
Reviewed-by: Darren Kenny <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>


  Commit: 996922de45299878cdc4c15b72b19edf2bc618a4
      
https://github.com/qemu/qemu/commit/996922de45299878cdc4c15b72b19edf2bc618a4
  Author: Jeff Cody <address@hidden>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M block/curl.c

  Log Message:
  -----------
  block/curl: fix minor memory leaks

Signed-off-by: Jeff Cody <address@hidden>
Reviewed-by: Richard W.M. Jones <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>


  Commit: 03c1c09d56bb242696fa07f9842b3a8f9fbcd46f
      
https://github.com/qemu/qemu/commit/03c1c09d56bb242696fa07f9842b3a8f9fbcd46f
  Author: Peter Maydell <address@hidden>
  Date:   2017-12-19 (Tue, 19 Dec 2017)

  Changed paths:
    M block/backup.c
    M block/curl.c
    M block/dirty-bitmap.c
    M block/sheepdog.c
    M blockjob.c
    M include/block/dirty-bitmap.h
    M include/qemu/hbitmap.h
    M tests/test-hbitmap.c
    M util/hbitmap.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into 
staging

# gpg: Signature made Mon 18 Dec 2017 21:05:53 GMT
# gpg:                using RSA key 0xBDBE7B27C0DE3057
# gpg: Good signature from "Jeffrey Cody <address@hidden>"
# gpg:                 aka "Jeffrey Cody <address@hidden>"
# gpg:                 aka "Jeffrey Cody <address@hidden>"
# Primary key fingerprint: 9957 4B4D 3474 90E7 9D98  D624 BDBE 7B27 C0DE 3057

* remotes/cody/tags/block-pull-request:
  block/curl: fix minor memory leaks
  block/curl: check error return of curl_global_init()
  block/sheepdog: code beautification
  block/sheepdog: remove spurious NULL check
  blockjob: kick jobs on set-speed
  backup: use copy_bitmap in incremental backup
  backup: simplify non-dirty bits progress processing
  backup: init copy_bitmap from sync_bitmap for incremental
  backup: move from done_bitmap to copy_bitmap
  hbitmap: add next_zero function

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/062fcb27c4c1...03c1c09d56bb
reply via email to
[Prev in Thread] Current Thread [Next in Thread]