qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] c6a1a9: qapi-schema: Fix query-vm-generation-

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] c6a1a9: qapi-schema: Fix query-vm-generation-id's doc comm...
Date: Wed, 20 Dec 2017 14:16:17 -0800 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c6a1a98b4222114fbebbb40814ba765ac4530937
      
https://github.com/qemu/qemu/commit/c6a1a98b4222114fbebbb40814ba765ac4530937
  Author: Markus Armbruster <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M qapi-schema.json

  Log Message:
  -----------
  qapi-schema: Fix query-vm-generation-id's doc comment markup

Reported-by: Daniel P. Berrange <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 67ab1ce9263f77b352faea1104f0ebc2e50a3d42
      
https://github.com/qemu/qemu/commit/67ab1ce9263f77b352faea1104f0ebc2e50a3d42
  Author: Markus Armbruster <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M scripts/qapi.py

  Log Message:
  -----------
  qapi: Stop rejecting #optional

Commit 1d8bda1 got rid of #optional tags, and added a check to keep
them from getting added back, to make sure patches then in flight
don't add them back.  It's been six months, time to drop that check.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 2281d00c3d75e684d9c0051169a6ac1cc60b66cd
      
https://github.com/qemu/qemu/commit/2281d00c3d75e684d9c0051169a6ac1cc60b66cd
  Author: Markus Armbruster <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M scripts/qapi.py

  Log Message:
  -----------
  qapi: Eliminate QAPISchemaParser.__init__()'s local fname

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 64d6033b203b32f02d0986220af5dc3cd1301ba6
      
https://github.com/qemu/qemu/commit/64d6033b203b32f02d0986220af5dc3cd1301ba6
  Author: Markus Armbruster <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M scripts/qapi.py

  Log Message:
  -----------
  qapi: Make cur_doc local to QAPISchemaParser.__init__()

QAPISchemaParser.cur_doc is used only by .__init__() and its helper
.reject_expr_doc().  Make it local to __init__() and pass it to
.reject_expr_doc() explicitly.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: cfa438ff53937c78c9a0e50b4b774ea5a6430710
      
https://github.com/qemu/qemu/commit/cfa438ff53937c78c9a0e50b4b774ea5a6430710
  Author: Markus Armbruster <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M tests/Makefile.include
    A tests/qapi-schema/doc-bad-section.err
    A tests/qapi-schema/doc-bad-section.exit
    A tests/qapi-schema/doc-bad-section.json
    A tests/qapi-schema/doc-bad-section.out
    M tests/qapi-schema/doc-good.json
    M tests/qapi-schema/doc-good.out
    M tests/qapi-schema/doc-good.texi

  Log Message:
  -----------
  tests/qapi-schema/doc-bad-section: New, factored out of doc-good

A negative test case crept into doc-good.json: invalid use of section
markup we currently fail to reject.  Move this into its own
doc-bad-section.json.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 0968dc9ae4d3f309c4ab4bddc2a69c8d9b2786ae
      
https://github.com/qemu/qemu/commit/0968dc9ae4d3f309c4ab4bddc2a69c8d9b2786ae
  Author: Markus Armbruster <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M scripts/qapi2texi.py

  Log Message:
  -----------
  qapi2texi: Clean up texi_sections()

Repurposing the function parameter doc for stepping through
doc.sections.__str__() is not nice.  Use new variable @text instead.

While there, eliminate variables name and func.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: fc3f0df18711121ddbcd04bac3a6abb3fb9392be
      
https://github.com/qemu/qemu/commit/fc3f0df18711121ddbcd04bac3a6abb3fb9392be
  Author: Markus Armbruster <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M scripts/qapi.py
    M scripts/qapi2texi.py
    M tests/qapi-schema/doc-bad-section.out
    M tests/qapi-schema/doc-good.out

  Log Message:
  -----------
  qapi: Unify representation of doc section without name

We have two representations of sections without a name: the main
section uses name=None, the others name=''.  Standardize on name=None.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 09331fced1c4e04109ccc9d6852f29e0453cf583
      
https://github.com/qemu/qemu/commit/09331fced1c4e04109ccc9d6852f29e0453cf583
  Author: Markus Armbruster <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M scripts/qapi.py
    M scripts/qapi2texi.py
    M tests/qapi-schema/doc-good.texi
    M tests/qapi-schema/test-qapi.py

  Log Message:
  -----------
  qapi: Simplify representation of QAPIDoc section text

Use a string instead of a list of strings.

This makes qapi2texi.py generate additional blank lines.  They're
harmless, and the next commit will get rid of them again.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 76eb6b60edbb15fd2f3beda7da3991951a3b8883
      
https://github.com/qemu/qemu/commit/76eb6b60edbb15fd2f3beda7da3991951a3b8883
  Author: Markus Armbruster <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M scripts/qapi2texi.py
    M tests/qapi-schema/doc-good.texi

  Log Message:
  -----------
  qapi2texi: Simplify representation of section text

Use a string instead of a list of strings.  While there, generate
fewer superfluous blank lines.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 8cbf1a537a61b2a1832948f20582839cebdb69de
      
https://github.com/qemu/qemu/commit/8cbf1a537a61b2a1832948f20582839cebdb69de
  Author: Markus Armbruster <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M scripts/qapi.py

  Log Message:
  -----------
  qapi: Rename QAPIDoc.parser, .section to ._parser, ._section

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 7e21572ce768a1b4cd4d4b24405d5f75448bbf62
      
https://github.com/qemu/qemu/commit/7e21572ce768a1b4cd4d4b24405d5f75448bbf62
  Author: Markus Armbruster <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M scripts/qapi2texi.py

  Log Message:
  -----------
  qapi2texi: De-duplicate code to add blank line before symbol

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 0b263ecbcf71273abc8f79762e2349841a003c27
      
https://github.com/qemu/qemu/commit/0b263ecbcf71273abc8f79762e2349841a003c27
  Author: Chen Hanxiao <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M docs/devel/qapi-code-gen.txt

  Log Message:
  -----------
  qapi-docs: fix a comment typo

  s/Subection/Subsection

Signed-off-by: Chen Hanxiao <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 49ccefde303c84d291c70842922c37b6de6ef15a
      
https://github.com/qemu/qemu/commit/49ccefde303c84d291c70842922c37b6de6ef15a
  Author: Daniel Henrique Barboza <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M qapi-schema.json
    M qmp.c

  Log Message:
  -----------
  qmp: remove qmp_cpu

'qmp_cpu' was implemented in commit 755f196898 ("qapi: Convert the cpu
command") as a functional no-op, a QMP call that does nothing and
return success. The idea, apparently, was to provide a counterpart
for the HMP 'hmp_cpu' command, introduced in the same commit.

After 6 years of its creation, qmp_cpu remains a functional no-op
that does nothing, having no value for any caller/user. A proposal
was sent to implement qmp_cpu like hmp_cpu works, but it was denied
[1]. The reason is that QMP must be as stateless as possible and a
function that changes its state (the current CPU monitor in the case
of qmp_cpu) goes against it. Any QMP command that needs a specific
monitor CPU setup must provide it in its arguments, instead of relying
in the current QMP monitor state.

After discussions that happened in [2] it was decided that a command
that does nothing since its birth, no one uses for anything and will
not be implemented, should be deprecated and erased. Given that we will
*not* provide any replacement for qmp_cpu and we believe that there
is no user relying on it, there is no point in adding a deprecation
delay for it.

So, this patch nukes qmp_cpu from QEMU code, removing both its blank
implementation in qmp.c and its doc in qapi-schema.json.

[1] https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg02283.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg03696.html

Signed-off-by: Daniel Henrique Barboza <address@hidden>
CC: Markus Armbruster <address@hidden>
CC: Eric Blake <address@hidden>
CC: Daniel P. Berrange <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 4da5c51cac8363f86ec92dc99c38f9382d617647
      
https://github.com/qemu/qemu/commit/4da5c51cac8363f86ec92dc99c38f9382d617647
  Author: Peter Maydell <address@hidden>
  Date:   2017-12-20 (Wed, 20 Dec 2017)

  Changed paths:
    M docs/devel/qapi-code-gen.txt
    M qapi-schema.json
    M qmp.c
    M scripts/qapi.py
    M scripts/qapi2texi.py
    M tests/Makefile.include
    A tests/qapi-schema/doc-bad-section.err
    A tests/qapi-schema/doc-bad-section.exit
    A tests/qapi-schema/doc-bad-section.json
    A tests/qapi-schema/doc-bad-section.out
    M tests/qapi-schema/doc-good.json
    M tests/qapi-schema/doc-good.out
    M tests/qapi-schema/doc-good.texi
    M tests/qapi-schema/test-qapi.py

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-12-20' into 
staging

QAPI patches for 2017-12-20

# gpg: Signature made Wed 20 Dec 2017 18:53:28 GMT
# gpg:                using RSA key 0x3870B400EB918653
# gpg: Good signature from "Markus Armbruster <address@hidden>"
# gpg:                 aka "Markus Armbruster <address@hidden>"
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-qapi-2017-12-20:
  qmp: remove qmp_cpu
  qapi-docs: fix a comment typo
  qapi2texi: De-duplicate code to add blank line before symbol
  qapi: Rename QAPIDoc.parser, .section to ._parser, ._section
  qapi2texi: Simplify representation of section text
  qapi: Simplify representation of QAPIDoc section text
  qapi: Unify representation of doc section without name
  qapi2texi: Clean up texi_sections()
  tests/qapi-schema/doc-bad-section: New, factored out of doc-good
  qapi: Make cur_doc local to QAPISchemaParser.__init__()
  qapi: Eliminate QAPISchemaParser.__init__()'s local fname
  qapi: Stop rejecting #optional
  qapi-schema: Fix query-vm-generation-id's doc comment markup

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/200780a3a3ed...4da5c51cac83
reply via email to
[Prev in Thread] Current Thread [Next in Thread]