[Qemu-commits] [qemu/qemu] afb92e: sdl2: fix hotkey keyup

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: afb92eb9852dbcdb5920e57179be20bcafab26a3
      
https://github.com/qemu/qemu/commit/afb92eb9852dbcdb5920e57179be20bcafab26a3
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ui/sdl2.c

  Log Message:
  -----------
  sdl2: fix hotkey keyup

After some hotkey was pressed sdl2 doesn't forward the first modifier
keyup event to the guest, resulting in stuck modifier keys.

Fix the logic in handle_keyup().  Also gui_key_modifier_pressed doesn't
need to be a global variable.

Reported-by: Howard Spoelstra <address@hidden>
Tested-by: Howard Spoelstra <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden


  Commit: 6e1f2cb56047980dba8c4199b00968914b514c28
      
https://github.com/qemu/qemu/commit/6e1f2cb56047980dba8c4199b00968914b514c28
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M include/ui/console.h
    M ui/console.c
    M ui/egl-headless.c

  Log Message:
  -----------
  console/opengl: split up dpy_gl_cursor ops

Split the cursor callback into two, one for setting the dmabuf,
one for setting the position.  Also add hotspot information.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: b09169282b3976075d434ae1cfd12de76ccbdcfd
      
https://github.com/qemu/qemu/commit/b09169282b3976075d434ae1cfd12de76ccbdcfd
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ui/egl-headless.c

  Log Message:
  -----------
  egl-headless: cursor_dmabuf: handle NULL cursor

The cursor dmabuf can be NULL, in case no cursor defined by the guest.
Happens for example when linux guests show the framebuffer console.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 41126214200bc6a0e4afe28f3a9d7888f5228d08
      
https://github.com/qemu/qemu/commit/41126214200bc6a0e4afe28f3a9d7888f5228d08
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ui/egl-helpers.c

  Log Message:
  -----------
  egl-helpers: add alpha channel to texture format

Needed when rendering cursers which (unlike framebuffers)
actually are transparent.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: fe5fca9a03ee965e039b8f5c0475032c9f950185
      
https://github.com/qemu/qemu/commit/fe5fca9a03ee965e039b8f5c0475032c9f950185
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ui/keymaps.c
    M ui/keymaps.h

  Log Message:
  -----------
  keymap: make struct kbd_layout_t private to ui/keymaps.c

Also use kbd_layout_t pointers instead of void pointers.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden


  Commit: d713e3fd4c1da510a31313e1d3cc51c89b8036f3
      
https://github.com/qemu/qemu/commit/d713e3fd4c1da510a31313e1d3cc51c89b8036f3
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ui/keymaps.c
    M ui/trace-events

  Log Message:
  -----------
  keymap: use glib hash for kbd_layout_t

Drop home-grown lookup code, which is a strange mix of a lookup table
and a list.  Use standard glib hash instead.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden


  Commit: 6b71ea1138307a0fbc0273df8866ca9879b7ba4c
      
https://github.com/qemu/qemu/commit/6b71ea1138307a0fbc0273df8866ca9879b7ba4c
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ui/keymaps.c

  Log Message:
  -----------
  keymap: numpad keysyms and keycodes are fixed

No need to figure them at runtime from the keymap.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden


  Commit: 23ad24e48cf28ac2542ade657efbf7f802d7c8a0
      
https://github.com/qemu/qemu/commit/23ad24e48cf28ac2542ade657efbf7f802d7c8a0
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ui/keymaps.c

  Log Message:
  -----------
  keymap: record multiple keysym -> keycode mappings

Sometimes the same keysym can be created using different key
combinations.  Record them all in the reverse keymap, not only
the first one.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden


  Commit: abb4f2c9655503f14dc55064f29c4f59b07e96ff
      
https://github.com/qemu/qemu/commit/abb4f2c9655503f14dc55064f29c4f59b07e96ff
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ui/curses.c
    M ui/keymaps.c
    M ui/keymaps.h
    M ui/sdl.c
    M ui/vnc.c

  Log Message:
  -----------
  keymap: consider modifier state when picking a mapping

Pass the modifier state to the keymap lookup function.  In case multiple
keysym -> keycode mappings exist look at the modifier state and prefer
the mapping where the modifier state matches.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden


  Commit: 0ce9cb913e32d7efed64dc1191a7a490d97cf56e
      
https://github.com/qemu/qemu/commit/0ce9cb913e32d7efed64dc1191a7a490d97cf56e
  Author: Peter Maydell <address@hidden>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M include/ui/console.h
    M ui/console.c
    M ui/curses.c
    M ui/egl-headless.c
    M ui/egl-helpers.c
    M ui/keymaps.c
    M ui/keymaps.h
    M ui/sdl.c
    M ui/sdl2.c
    M ui/trace-events
    M ui/vnc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180222-pull-request' 
into staging

ui: reverse keymap improvements.
sdl2: hotkey fix.
opengl: dmabuf fixes.

# gpg: Signature made Thu 22 Feb 2018 10:22:58 GMT
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/ui-20180222-pull-request:
  keymap: consider modifier state when picking a mapping
  keymap: record multiple keysym -> keycode mappings
  keymap: numpad keysyms and keycodes are fixed
  keymap: use glib hash for kbd_layout_t
  keymap: make struct kbd_layout_t private to ui/keymaps.c
  egl-helpers: add alpha channel to texture format
  egl-headless: cursor_dmabuf: handle NULL cursor
  console/opengl: split up dpy_gl_cursor ops
  sdl2: fix hotkey keyup

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/ff8689611a1d...0ce9cb913e32