Re: [Qemu-devel] [PATCH] DOSEMU image file support

[Fabrice Bellard]

Hampa Hug wrote:
> Fabrice Bellard wrote:
>
>
> > Thank you for the patch. Two remarks if you want that I merge it:
> >
> > 1) use open/read/write/close instead of fopen/fread/fwrite/fclose for 
> > consistency with other block drivers.
>
>
> The reason I used stdio is that read/write are non-blocking. It is
> not an error for read to return fewer bytes than requested. If that
> happens, the other block drivers fail.

I agree, but for disk accesses it is usual to assume they return the 
requested amount of bytes. fread/fwrite are buffered I/Os which is a bit 
overkill for block drivers.

> > 2) change the license to BSD
>
>
> I was under the impression that we used GPL. At least that's what
> COPYING says.

The different parts of QEMU have different licenses (and of course it 
affects the license of the resulting program). As mentionned on the web 
page:

- The QEMU virtual CPU core library is released under the GNU Lesser 
General Public License.
- The Linux QEMU emulator is released under the GNU General Public License.
- The QEMU PC system emulator is released under the MIT/BSD License.

The block layer belongs to the QEMU PC system emulator, so its license 
is BSD.

Fabrice.