[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] linux-user/mmap.c query
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] linux-user/mmap.c query |
Date: |
Fri, 24 Sep 2004 00:44:47 +0100 |
User-agent: |
KMail/1.7 |
On Wednesday 22 September 2004 23:16, address@hidden wrote:
> BTW, is it possible to run qemu-arm under gdb and get breakpoints working?
> When I try, gdb complains because the qemu binary is remapped somewhere
> else in the addres space.
Configure with --static.
> --- linux-user/mmap.c 5 Jul 2004 21:25:16 -0000 1.7
> +++ linux-user/mmap.c 22 Sep 2004 20:18:53 -0000
> @@ -182,7 +182,7 @@
> }
> #endif
>
> - if (offset & ~TARGET_PAGE_MASK)
> + if (offset & ~TARGET_PAGE_MASK && 0)
> return -EINVAL;
>
> len = TARGET_PAGE_ALIGN(len);
Isn't this just papering over the problem? What about the other places in that
function which return -EINVAL?
Also the later code handles host misalignment, whereas this test if for target
misalignment.
Paul