[Qemu-devel] qemu cvs warnings

[Juergen Lock]

Hi!

 building from cvs i get a few warnings that may be noteworthy:

1.

gcc33 -I/usr/local/include -Wall -O2 -g -fno-strict-aliasing 
-fomit-frame-pointer -mpreferred-stack-boundary=2 -falign-functions=0 -fno-gcse 
-fno-reorder-blocks -fno-optimize-sibling-calls -I. 
-I/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386 
-I/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23 -D_GNU_SOURCE 
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DSMBD=\"/usr/local/sbin/smbd\" 
-I/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/slirp -c -o op.o 
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/op.c
In file included from 
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/exec.h:143,
                 from 
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/op.c:22:
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/exec-all.h:319:1: 
warning: "ASM_NAME" redefined
In file included from 
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/exec.h:21,
                 from 
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/op.c:22:
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/dyngen-exec.h:214:1: 
warning: this is the location of the previous definition

 (and some more of these with other files)

2.

gcc33 -I/usr/local/include -Wall -O2 -g -fno-strict-aliasing 
-fomit-frame-pointer -I. 
-I/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-ppc 
-I/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23 -D_GNU_SOURCE 
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DSMBD=\"/usr/local/sbin/smbd\" 
-I/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/slirp -c -o 
openpic.o 
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/hw/openpic.c
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/hw/openpic.c: In 
function `openpic_timer_write':
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/hw/openpic.c:632: 
warning: integer constant is too large for "long" type

 this seems to be a bug (one digit too many):

Index: qemu/hw/openpic.c
@@ -629,7 +629,7 @@
         break;
     case 0x10: /* TIBC */
        if ((opp->timers[idx].ticc & 0x80000000) != 0 &&
-           (val & 0x800000000) == 0 &&
+           (val & 0x80000000) == 0 &&
             (opp->timers[idx].tibc & 0x80000000) != 0)
            opp->timers[idx].ticc &= ~0x80000000;
        opp->timers[idx].tibc = val;

3.

gcc33 -I/usr/local/include -Wall -O2 -g -fno-strict-aliasing 
-fomit-frame-pointer -mpreferred-stack-boundary=2 -falign-functions=0 -fno-gcse 
-fno-reorder-blocks -fno-optimize-sibling-calls -I. 
-I/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386 
-I/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23 -D_GNU_SOURCE 
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DSMBD=\"/usr/local/sbin/smbd\" 
-I/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/slirp -c -o op.o 
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/op.c
 ...
In file included from 
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/op.c:733:
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/ops_template.h:
 In function `compute_all_incq':
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/ops_template.h:182:
 warning: integer constant is too large for "long" type
In file included from 
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/op.c:733:
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/ops_template.h:
 In function `compute_all_decq':
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/ops_template.h:204:
 warning: integer constant is too large for "long" type
In file included from 
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/op.c:733:
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/ops_template.h:
 In function `op_shrq_T0_T1':
/usr/ports/emulators/qemu/work/qemu-snapshot-2005-01-09_23/target-i386/ops_template.h:436:
 warning: integer constant is too large for "long" type

 and many more of these, which all seem to be caused by the definition of
DATA_MASK for the DATA_BITS == 64 case:
        #define DATA_MASK 0xffffffffffffffff
I guess this should be
        #define DATA_MASK 0xffffffffffffffffLL

 (maybe it doesnt really matter because the constant gets sign-extended,
but still...)

        Juergen