Re: [Qemu-devel] [PATCH] Win32 build

[Filip Navara]

Fabrice Bellard wrote:

> Filip Navara wrote:
>
> > Index: target-i386/ops_template.h
> > ===================================================================
> > RCS file: /cvsroot/qemu/qemu/target-i386/ops_template.h,v
> > retrieving revision 1.8
> > diff -u -r1.8 ops_template.h
> > --- target-i386/ops_template.h    3 Jan 2005 23:50:08 -0000    1.8
> > +++ target-i386/ops_template.h    9 Jan 2005 02:18:37 -0000
> > @@ -46,7 +46,7 @@
> >  #define SUFFIX q
> >  #define DATA_TYPE uint64_t
> >  #define DATA_STYPE int64_t
> > -#define DATA_MASK 0xffffffffffffffff
> > +#define DATA_MASK 0xffffffffffffffffULL
> >  #else
> >  #error unhandled operand size
> >  #endif
>
>
> Is this really needed to compile ? 

GCC reports lots of warnings like these otherwise:

qemu/target-i386/ops_template.h: In function `compute_all_incq':
qemu/target-i386/ops_template.h:182: warning: integer constant is too 
large for "long" type
In file included from e:/DIFFs/qemu/target-i386/op.c:733:
qemu/target-i386/ops_template.h: In function `compute_all_decq':
qemu/target-i386/ops_template.h:204: warning: integer constant is too 
large for "long" type
In file included from e:/DIFFs/qemu/target-i386/op.c:733:
qemu/target-i386/ops_template.h: In function `op_shrq_T0_T1':
qemu/target-i386/ops_template.h:436: warning: integer constant is too 
large for "long" type

- Filip