Re: [Qemu-devel] [PATCH] Win32 support for the GDB stub

[malc]

On Sat, 22 Jan 2005, Filip Navara wrote:

> malc wrote:
>
> > On Sat, 22 Jan 2005, Filip Navara wrote:
> >
> > > just what the subject says...
> >
> >
> > Why guards around recv/read send/write?
>
> Sockets are Win32 handles, while handles from "open" & friends are CRT 
> handles. You can't call "read"/"write" on socket handle in Win32.

But you can call recv/send, on any fd, under *nixes, so the guards are
strictly speaking unecessary (given that MSG_NOSGINAL is passed to
recv/send, MSG_NOSIGNAL must be defined to 0 for WIN32, thus reducing
the number of guards to the bare minimum)

> > And to the best of my knowlege
> > checking errno after WSA calls wouldn't do much good, WSAGetError should
> > be used, though i might be way off here.
>
> You mean in the gdbstub.c code? I simply overlooked that...

Yes.

--
mailto:address@hidden