Re: [Qemu-devel] [PATCH] Fix OS X SDL breakage

[Daniel Egger]

On 26.01.2005, at 20:47, Fabrice Bellard wrote:

> Can you confirm that QEMU for OS X works with this include ?

I can confirm that the relevant part *compiles* *without* it
i.e. after the applying the patch. Including the include it'll
fail the compilation of vl.o failes because the included file
is not in search path (and cannot be on a sane configuration
I might add).

> IMHO it was added to add the '#define main SDL_main' define.

Why would OS X be any different than say Linux in this regard?

Iff the inclusion of SDL.h was needed, it would be better to
unconditionally #include <SDL.h> on all architectures and fix
the makefile to use `sdl-config --cflags` in addition to the
regular switches for vl.o.

But since OS X still miscompiles the uops the proof is in the
pudding...

Servus,
      Daniel

PGP.sig
Description: This is a digitally signed message part