Re: [Qemu-devel] Qemu arm emulation

[Ulrich Hecht]

Hi!

On Friday 04 February 2005 15:19, Paul Brook wrote:
> On Friday 04 February 2005 12:30, Ulrich Hecht wrote:
> > +void OPPROTO op_movl_T1_im_cc(void)
> > +{
> > +    T1 = PARAM1;
> > +    env->CF = PARAM1 >> 31;
> > +}
>
> This should be "((uint32_t) PARAM1) >> 31".
> The comments say CF is 0 or 1. PARAM1 is signed, so your code will
> result in 0 or -1 on 32-bit hosts.
>
> >              /* XXX: is CF modified ? */
>
> Probably want to remove this comment now.

OK.

CU
Uli

qemu-shifter_carry.patch
Description: Text Data